PVS-Studio report

[Xisco Fauli]

Hello,

Unfortunately now it's flagging a lot of issues like

const SfxBoolItem* pStateItem = dynamic_cast<const SfxBoolItem*>( pItem  );
assert(pStateItem); // SfxBoolItem expected
if (pStateItem)
↑ V547 Expression 'pStateItem' is always true.

which is not ideal either, so I updated the report again without 
//V_ASSERT_CONTRACT

On 25/11/24 10:09, Xisco Fauli wrote:
>
> Hello,
>
> On 21/11/24 13:41, Caolán McNamara wrote:
>> On Thu, 2024-11-21 at 12:51 +0100, Xisco Fauli wrote:
>>> -> it can be fixed with
>>> https://pvs-studio.com/en/docs/manual/0040/#IDBD1CC960F7
>> Do I read it right, that it just has to see the comment somewhere, e.g.
>> if added to include/sal/config.h to treat all asserts like that ?
>
> Yes, that's one way. The other one is to pass a config file to 
> pvs-studio-analyzer with the -R flag. 
> https://report.dev.libreoffice.org/ has been updated using 
> //V_ASSERT_CONTRACT
>
> -- 
> Xisco Faulí
> LibreOffice QA Team
> IRC: x1sc0

-- 
Xisco Faulí
LibreOffice QA Team
IRC: x1sc0
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20241127/1582b386/attachment.htm>