Interdependent, failing commits

[Noel Grandin]

Should be fixed once https://gerrit.libreoffice.org/c/core/+/179890 goes in

On Tue, 7 Jan 2025 at 01:04, Bjoern Michaelsen <
bjoern.michaelsen-tdf at libreoffice.org> wrote:

> Hi Stephan,
>
> ok from my site. While I am still working on a fix, it was unfortunately
> not as trivial as I thought and I currently do not find the time to
> commit to fix this by tomorrow.
>
> Best,
>
> Bjoern
>
> On 1/6/25 22:27, Stephan Bergmann wrote:
> > The two recent commits <https://git.libreoffice.org/core/+/
> > d8e29e2697e90da6acf5858fd74d6054ed9e5aa3%5E%21> "Revert 'Revert
> > 'stronger typing for SwClient::GetRegisteredIn'' and fix SwIterator
> > cast" and <https://git.libreoffice.org/core/
> > +/404fbec25740406e3b926844f3bd0f324dc38b8c%5E%21> "convert
> > RES_ATTRSET_CHG to SfxHint" are both known-broken and cause at least
> > UBSan builds to fail (see the comments at <https://
> > gerrit.libreoffice.org/c/core/
> > +/179480/3#message-1d186afad4accdcf814507953175bf0e483b0e2e> and
> > <https://gerrit.libreoffice.org/c/core/+/179772/6#message-
> > e7324ab2f8feb8f37c28a4f8845176d82f658648>, respectively).
> >
> > Now, a third commit <https://git.libreoffice.org/core/
> > +/404fbec25740406e3b926844f3bd0f324dc38b8c%5E%21> "convert
> > RES_ATTRSET_CHG to SfxHint" interferes with (local) reverts of the other
> > two commits, so it becomes increasingly messy to try and keep a
> > successful (local) UBsan build, and keep an eye on further commits that
> > could potentially introduce further/unrelated breakage.
> >
> > Therefore, unless there are fixes for the two known-broken commits
> > available by then, I suggest to revert for now all three of those
> > commits tomorrow evening.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/libreoffice/attachments/20250107/4bd9f1e0/attachment.htm>