[Libva] Decoding artefacts

Tue Dec 27 09:51:13 PST 2011

Guys !

I found the cause of the additional macroblocking issue in XBMC. I
used the unstable Ubuntu ppa and the last uploaded version was just in
between a wrong ffmpeg commit which was reverted a few commits later:

https://github.com/xbmc/xbmc/commits/master?page=4

The ppa revision was f1ae0b6. You can see that it is right in the
unreverted ffmpeg patch state. So this was another issue we were
having.

With a fresh build from GIT AND Haihao's intel-vaapi driver patch
everything is fine without any artfacts in both XBMC AND mplayer.

So everything is solved with Haihao's patch.

Cheers, Alan

2011/12/27 alanwww1 <alanwww1 at gmail.com>:
> With the new patch, I have no issues with latest mpalyer-vaapi with
> any sample I tried. All were clear.
> But I do have major issues in xbmc at the moment. I am not sure what
> is the difference, but I will try to make compiles with earlier xbmc
> revisions if something went wrong from Dharma to Eden. Or if it is a
> borked driver or installation problem on my machine.
>
> I'll report as I know what is the clear situation.
>
> 2011/12/27 Staffan Lindberg <pike at xbmc.org>:
>> did you test the fright night sample ? gimli says he can't see any issues
>> with it
>>
>>
>> On Tue, Dec 27, 2011 at 11:25 AM, alanwww1 <alanwww1 at gmail.com> wrote:
>>>
>>> Hello Haihao !
>>>
>>> The patch fixes the problem in mplayer compiled with ffmpeg 0.9. In
>>> xbmc I still have problems, but maybe I seem to have another issue
>>> there. I'll check that later, but the patch definatelly works !
>>>
>>> Thanks, please commit it if possible.
>>>
>>> Cheers, Alan
>>>
>>> 2011/12/27 gimli <gimli at dark-green.com>:
>>> > I can confirm this also fixes my problem wit the decoding artefacts.
>>> >
>>> > On Tue, 27 Dec 2011 09:50:41 +0800, "Xiang, Haihao"
>>> > <haihao.xiang at intel.com>
>>> > wrote:
>>> >>> I was able to reproduce the problem on mplayer (1.0+svn32819-3 built
>>> >>> on 2011.10.22.). It looks a lot better than in xbmc, but macroblocking
>>> >>> is definatelly there.
>>> >>
>>> >> I also reproduced this issue with the new sample. It seems it is the
>>> >> same issue of https://bugs.freedesktop.org/show_bug.cgi?id=40820. Here
>>> >> is the patch https://bugs.freedesktop.org/attachment.cgi?id=51444 for
>>> >> this issue. Could you give a try ?
>>> >>
>>> >> Thanks
>>> >> Haihao
>>> >>
>>> >>
>>> >>>
>>> >>> One important thing I noticed. If I seek into any position of the
>>> >>> movie. The is NO macroblocking at that position, where is a lot of
>>> >>> macroblocking when I play it back normally from an earlier position.
>>> >>> This info could be important. Here are the screenshots:
>>> >>>
>>> >>> macroblocking screenshot in mplayer:
>>> >>> http://img716.imageshack.us/img716/3643/screenshotmlpayer.png
>>> >>> macroblocking screenshot in xbmc:
>>> >>> http://img830.imageshack.us/img830/152/screenshot007zs.png
>>> >>> screenshot seeking into position xbmc:
>>> >>> http://img714.imageshack.us/img714/6767/screenshot006tj.png
>>> >>>
>>> >>> Please, libva devs, could you please help ?
>>> >>>
>>> >>> Thx,
>>> >>>
>>> >>> Alan
>>> >>>
>>> >>> 2011/12/26 alanwww1 <alanwww1 at gmail.com>:
>>> >>> > So it is for sure that the problem is not in xbmc I guess, but in
>>> >>> > ffmpeg or libva.
>>> >>> >
>>> >>> > Can you check the version or build date of the arch linux mplayer
>>> >>> > package ?
>>> >>> >
>>> >>> > Just for the libva devs as an info that the problem also exists in
>>> >>> > mplayer and not only in xbmc.
>>> >>> >
>>> >>> > Thanks.
>>> >>> >
>>> >>> > ps.:
>>> >>> > I am also trying to build a fresh mplayer on Ubuntu to confirm.
>>> >>> >
>>> >>> >
>>> >>> >
>>> >>> > 2011/12/26 gimli <gimli at dark-green.com>:
>>> >>> >> I use the archlinux distribution packages. For ffmpeg tests i use
>>> >>> >> my
>>> >>> >> xine
>>> >>> >> vaapi implementation.
>>> >>> >>
>>> >>> >> On Mon, 26 Dec 2011 18:30:47 +0100, alanwww1 <alanwww1 at gmail.com>
>>> >>> >> wrote:
>>> >>> >>> Hi Gimli !
>>> >>> >>>
>>> >>> >>> As i know that is only working with earlier mplayer builds. If you
>>> >>> >>> check out a fresh build with
>>> >>> >>>
>>> >>> >>> git clone -b hwaccel-vaapi
>>> >>> >>> git://git.gitorious.org/vaapi/mplayer.git
>>> >>> >>>
>>> >>> >>> You can only have the -vo option. -va is depricated as I
>>> >>> >>> understand.
>>> >>> >>>
>>> >>> >>> What version have you compiled or from which git repository ?
>>> >>> >>>
>>> >>> >>> I am really stuck getting a working vaapi enabled mplayer on my
>>> >>> >>> system.
>>> >>> >>>
>>> >>> >>> Thx
>>> >>> >>>
>>> >>> >>>
>>> >>> >>> 2011/12/26 gimli <gimli at dark-green.com>
>>> >>> >>>>
>>> >>> >>>> Did you try run vaapi mplayer with :
>>> >>> >>>>
>>> >>> >>>> mplayer -vo vaapi -va vaapi file.mkv ?
>>> >>> >>>>
>>> >>> >>>> On Mon, 26 Dec 2011 12:03:43 +0100, alanwww1 <alanwww1 at gmail.com>
>>> >>> >>>> wrote:
>>> >>> >>>> > Hi Haihao !
>>> >>> >>>> >
>>> >>> >>>> > Thanks for the help !
>>> >>> >>>> >
>>> >>> >>>> > I tried to backport the only commit that has something to do
>>> >>> >>>> > with
>>> >>> >> vaapi
>>> >>> >>>> > h264 decoding. I applied this to internal xbmc ffmpeg. The
>>> >>> >>>> > internal
>>> >>> >>>> ffmpeg
>>> >>> >>>> > is dated february 2011. So this is the only commit which is not
>>> > in
>>> >>> >>>> > it:
>>> >>> >>>> >
>>> >>> >>>> >
>>> >>> >>>>
>>> >>> >>
>>> >
>>> > http://git.videolan.org/?p=ffmpeg.git;a=commit;h=3fec40b601827e75aae9f0baa47671af15de181a
>>> >>> >>>> >
>>> >>> >>>> >
>>> >>> >>>> >
>>> >>> >>>> > Compiles fine, but the same marcroblocking artifacts.
>>> >>> >>>> > Unfortunately I
>>> >>> >>>> > am
>>> >>> >>>> > not able to run a vaapi enabled mplayer to test that. See my
>>> >>> >>>> > post
>>> >>> >> about
>>> >>> >>>> > this problem:
>>> >>> >>>> >
>>> >>> >>>> >
>>> > http://lists.freedesktop.org/archives/libva/2011-December/000734.html
>>> >>> >>>> >
>>> >>> >>>> > So I have not ideahow to solve this.
>>> >>> >>>> >
>>> >>> >>>> >
>>> >>> >>>> > 2011/12/26 gimli <gimli at dark-green.com>
>>> >>> >>>> >
>>> >>> >>>> >> Here is my sample where you can see my issue.
>>> >>> >>>> >>
>>> >>> >>>> >> http://www.megaupload.com/?d=T9KYT771
>>> >>> >>>> >> http://www.megaupload.com/?d=R0SAJ8EY
>>> >>> >>>> >>
>>> >>> >>>> >> Sorry. Didn't find a better place for the smales.
>>> >>> >>>> >>
>>> >>> >>>> >>
>>> >>> >>>> >> On Mon, 26 Dec 2011 16:21:55 +0800, "Xiang, Haihao"
>>> >>> >>>> >> <haihao.xiang at intel.com>
>>> >>> >>>> >> wrote:
>>> >>> >>>> >> > On Mon, 2011-12-26 at 01:11 +0100, alanwww1 wrote:
>>> >>> >>>> >> >> Hello Gimli !
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> I have the same problem on Intel Sandy Bridge. I tested
>>> >>> >>>> >> >> with
>>> >>> >>>> >> >> xbmc
>>> >>> >>>> >> >> and
>>> >>> >>>> >> >> latest libva and intel driver. But it is the same with
>>> >>> >>>> >> >> older
>>> >>> >>>> >> >> drivers.
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> Here are some screenshots:
>>> >>> >>>> >> >> http://img607.imageshack.us/img607/841/screenshot004u.png
>>> >>> >>>> >> >> http://img85.imageshack.us/img85/6752/screenshot003g.png
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> And here is the sample video.
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> > http://jkft.info/xbmc/testfiles/h264_macroblocking/2012-sample.mkv
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> Would be good if libva devs can confirm this. If it is
>>> >>> >>>> >> >> maybe
>>> >>> >>>> >> >> an
>>> >>> >>>> >> >> already known problem.
>>> >>> >>>> >> >
>>> >>> >>>> >> > I can't reproduce this issue with the latest mplayer-vaapi
>>> >>> >>>> >> > and
>>> >>> >>>> >> > VLC.
>>> >>> >>>> >> > I didn't test xbmc because I failed to build xbmc on my
>>> >>> >>>> >> > machine,
>>> >>> >> but
>>> >>> >>>> >> > I
>>> >>> >>>> >> > noticed xbmc uses an internal FFmpeg library by default. Is
>>> >>> >>>> >> > that
>>> >>> >> the
>>> >>> >>>> >> > reason why you have artifacts in XBMC ?
>>> >>> >>>> >> >
>>> >>> >>>> >> > Thanks
>>> >>> >>>> >> > Haihao
>>> >>> >>>> >> >
>>> >>> >>>> >> >
>>> >>> >>>> >> >
>>> >>> >>>> >> >
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> Thanks, Alan
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> 2011/12/25 gimli <gimli at dark-green.com>
>>> >>> >>>> >> >>         I have seen decoding artefacts with some h264
>>> > streams.
>>> >>> >>>> >> >> Latest
>>> >>> >>>> >> >>         ffmpeg and
>>> >>> >>>> >> >>         mplayer-vaapi.
>>> >>> >>>> >> >>         Where can i stick a sample file and an image which
>>> >>> >>>> >> >>         shows
>>> >>> >>>> >> >> the
>>> >>> >>>> >> >>         artefact ?
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>         _______________________________________________
>>> >>> >>>> >> >>         Libva mailing list
>>> >>> >>>> >> >>         Libva at lists.freedesktop.org
>>> >>> >>>> >> >>         http://lists.freedesktop.org/mailman/listinfo/libva
>>> >>> >>>> >> >>
>>> >>> >>>> >> >>
>>> >>> >>>> >> >> _______________________________________________
>>> >>> >>>> >> >> Libva mailing list
>>> >>> >>>> >> >> Libva at lists.freedesktop.org
>>> >>> >>>> >> >> http://lists.freedesktop.org/mailman/listinfo/libva
>>> >>> >>>> >>
>>> >>> _______________________________________________
>>> >>> Libva mailing list
>>> >>> Libva at lists.freedesktop.org
>>> >>> http://lists.freedesktop.org/mailman/listinfo/libva
>>
>>
>>
>>
>> --
>> pike • XBMC Project Manager • http://xbmc.org
>> XBMC - Best Multiplatform MediaCenter IN•THE•WORLD - on Linux, OSX & Windows