[Libva] [PATCH] Make VADriverContext.vtable a pointer

Gwenole Beauchesne gbeauchesne at splitted-desktop.com
Mon Jan 31 02:16:42 PST 2011


Hi,

In order to avoid future breakage to drivers built against a specific 
version of libva, I suggest we make the vtable a pointer. That structure 
will be maintained (allocated/deallocated) by libva. Besides, this 
structure can only grow in order to provide backwards compatibility.

e.g. the vaQuerySurfaceError() hook should have been placed at the end of 
the VTable. Anyway, now that we bumped the VA-API version and new libva 
versions will check for __vaDriverInit_0_32, we don't have to move it.

With simple changes similar to patches 302 & 303, the drivers I maintain 
(vdpau-driver, xvba-driver) can expose both __vaDriverInit_0_31 and 
__vaDriverInit_0_32, thus making it possible to remain compatible with any 
libva version around.

Thanks,
Gwenole.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0301-Make-VADriverContext.vtable-a-pointer.patch
Type: text/x-diff
Size: 18929 bytes
Desc: 
URL: <http://lists.freedesktop.org/archives/libva/attachments/20110131/ef6adf07/attachment.patch>


More information about the Libva mailing list