[Libva] [PATCH] Fix the issue in i965_UnlockSurface to lock it next time
yakui.zhao at intel.com
Thu Oct 18 21:54:02 PDT 2012
On Thu, 2012-10-18 at 22:07 -0600, Gwenole Beauchesne wrote:
> 2012/10/19 ykzhao <yakui.zhao at intel.com>:
> > On Tue, 2012-10-09 at 07:19 -0600, Zhao, Yakui wrote:
> >> From: Zhao Yakui <yakui.zhao at intel.com>
> >> It uses the variable of locked_image_id to check whether one surface is locked
> >> or not. But as the locked_image_id is not assigned correctly, it causes that
> >> it can't lock one surface next time although it calls the vaUnlockSurfaces.
> > Any comment about this patch?
> I think you should move the assignment down after the "error:" clause
> and s/error/end/ because otherwise, you wouldn't be able to lock a
> surface again if an error occurred. Then, it should be fine.
thanks for your review.
OK. I will update it.
More information about the Libva