[Libva] [PATCH 1/5] Fix the issue in i965_UnlockSurface to lock it next time

yakui.zhao at intel.com yakui.zhao at intel.com
Mon Oct 29 23:50:32 PDT 2012


From: Zhao Yakui <yakui.zhao at intel.com>

It uses the variable of locked_image_id to check whether one surface is locked
or not. But as the locked_image_id is not assigned correctly, it causes that
it can't lock one surface next time although it calls the vaUnlockSurfaces.
Then the libva trace log can't dump the content of decoded/
encoded surface even after adding LIBVA_TRACE_SURFACE=XXX.

Signed-off-by: Zhao Yakui <yakui.zhao at intel.com>
Reviewed-by: Gwenole Beauchesne <gb.devel at gmail.com>
---
 src/i965_drv_video.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/i965_drv_video.c b/src/i965_drv_video.c
index 771f603..16f0343 100755
--- a/src/i965_drv_video.c
+++ b/src/i965_drv_video.c
@@ -3638,11 +3638,11 @@ i965_UnlockSurface(
 
     if (obj_surface == NULL) {
         vaStatus = VA_STATUS_ERROR_INVALID_PARAMETER;   // Surface is absent
-        goto error;
+        return vaStatus;
     }
     if (obj_surface->locked_image_id == VA_INVALID_ID) {
         vaStatus = VA_STATUS_ERROR_INVALID_PARAMETER;   // Surface is not locked
-        goto error;
+        return vaStatus;
     }
 
     locked_img = IMAGE(obj_surface->locked_image_id);
@@ -3669,6 +3669,8 @@ i965_UnlockSurface(
     locked_img->image.image_id = VA_INVALID_ID;
 
  error:
+    obj_surface->locked_image_id = VA_INVALID_ID;
+
     return vaStatus;
 }
 
-- 
1.7.12-rc1



More information about the Libva mailing list