[Libva] [PATCH] i965_device_info: add CBR and VBR rate control flags for vdenc

[Sreerenj]

On 12.08.2016 20:19, Sean V Kelley wrote:
> On Fri, 2016-08-12 at 16:20 +0300, Sreerenj wrote:
>>
>> On 12.08.2016 14:20, Sreerenj wrote:
>>>
>>> On 11.08.2016 19:47, Sean V Kelley wrote:
>>>>
>>>> On Thu, 2016-08-11 at 14:55 +0300, sreerenj.balachandran at intel.co
>>>> m wrote:
>>>>> From: Sreerenj Balachandran <sreerenj.balachandran at intel.com>
>>>>>
>>>>> Low power encode through VDENC supports both CBR and VBR.
>>>>> Make sure vaGetConfigAttribute correctly returns the supported
>>>>> list of rate control modes in VAEntrypointEncSliceLP
>>>>> entrypoint.
>>>> This was intentional.  I'd prefer to delay this until we get the
>>>> GuC/HuC kernel patches merged.  BRC depends on the HuC
>>>> firmware...
>>>   
>>> IIUC, HuC support is from BXT onwards, right?
>>> Which means no BRC for SKL VDENC ??
>>   
>> Also, what matters for "skl + vdenc + h264 enc", is GuC firmware
>> which is already landed in linux-firmware,
>> http://git.kernel.org/cgit/linux/kernel/git/firmware/linux-firmware.g
>> it/commit/?id=0a0c97667d0e80c56de8fd999d17bf2b553aab8f
>>
>> Kernel patches are also in place in upstream kernel for GuC
>> loading...
> GuC is not required for VDENC CQP.  Your patch though is addressing
> CBR/VBR.  :-)
>
> HuC is needed for BRC.  In fact the primary dependency for GuC kernel
> patches is handling the HuC firmware and exposing status.

K, Thanks Sean...

> Thanks,
>
> Sean
>
>>>> https://patchwork.freedesktop.org/series/9011/
>>>>
>>>> I'm also trying to get an interface (outside of debugfs) for the
>>>> driver to detect HuC FW loading
>>>> status in the  revised/new patch set. We'll be reusing
>>>> I915_GETPARAM likely.
>>>>
>>>>
>>>> Thanks,
>>>>
>>>> Sean
>>>>
>>>>> ---
>>>>>   src/i965_device_info.c | 2 +-
>>>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/src/i965_device_info.c b/src/i965_device_info.c
>>>>> index 47fd50a..a3a1027 100644
>>>>> --- a/src/i965_device_info.c
>>>>> +++ b/src/i965_device_info.c
>>>>> @@ -361,7 +361,7 @@ static struct hw_codec_info
>>>>> skl_hw_codec_info = {
>>>>>       .has_hevc_encoding = 1,
>>>>>       .has_lp_h264_encoding = 1,
>>>>>   
>>>>> -    .lp_h264_brc_mode = VA_RC_CQP,
>>>>> +    .lp_h264_brc_mode = VA_RC_CQP | VA_RC_CBR | VA_RC_VBR,
>>>>>   
>>>>>       .num_filters = 5,
>>>>>       .filters = {
>>>   
>>   
>> -- 
>> Thanks
>> Sree
>> ---------------------------------------------------------------------
>> Intel Finland Oy
>> Registered Address: PL 281, 00181 Helsinki
>> Business Identity Code: 0357606 - 4
>> Domiciled in Helsinki
>> This e-mail and any attachments may contain confidential material for
>> the sole use of the intended recipient(s). Any review or distribution
>> by others is strictly prohibited. If you are not the intended
>> recipient, please contact the sender and delete all copies.

-- 
Thanks
Sree

---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.