Mesa (master): i915g: TODO about untested code hidden behind caps
Jakob Bornecrantz
wallbraker at kemper.freedesktop.org
Mon Feb 21 23:54:41 UTC 2011
Module: Mesa
Branch: master
Commit: e7cdcefbee6c8bffdc421f38d97578180e7991b5
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e7cdcefbee6c8bffdc421f38d97578180e7991b5
Author: Jakob Bornecrantz <wallbraker at gmail.com>
Date: Sun Feb 20 13:58:11 2011 +0100
i915g: TODO about untested code hidden behind caps
Should be fairly easy to test and fix since you can look at
the code in the classic driver.
---
src/gallium/drivers/i915/TODO | 3 +++
src/gallium/drivers/i915/i915_screen.c | 8 ++++++--
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/i915/TODO b/src/gallium/drivers/i915/TODO
index 94c428b..0becf31 100644
--- a/src/gallium/drivers/i915/TODO
+++ b/src/gallium/drivers/i915/TODO
@@ -1,5 +1,8 @@
Random list of problems with i915g:
+- Check if PIPE_CAP_BLEND_EQUATION_SEPARATE and PIPE_CAP_TEXTURE_MIRROR_REPEAT
+ work, the code is there. If not fix it! A simple task, good for beginners.
+
- Dies with BadDrawable on GLXFBconfig changes/destruction. Makes piglit totally
unusable :( Upgrading xserver helped here, it doesn't crash anymore. Still
broken, it doesn't update the viewport/get new buffers.
diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c
index 31a8134..232262a 100644
--- a/src/gallium/drivers/i915/i915_screen.c
+++ b/src/gallium/drivers/i915/i915_screen.c
@@ -108,10 +108,15 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
case PIPE_CAP_TWO_SIDED_STENCIL:
return 1;
+ /* Features that should be supported (boolean caps). */
+ /* XXX: Just test the code */
+ case PIPE_CAP_BLEND_EQUATION_SEPARATE:
+ case PIPE_CAP_TEXTURE_MIRROR_REPEAT:
+ return 0;
+
/* Unsupported features (boolean caps). */
case PIPE_CAP_ANISOTROPIC_FILTER:
case PIPE_CAP_ARRAY_TEXTURES:
- case PIPE_CAP_BLEND_EQUATION_SEPARATE:
case PIPE_CAP_DEPTH_CLAMP:
case PIPE_CAP_DEPTHSTENCIL_CLEAR_SEPARATE: /* disable for now */
case PIPE_CAP_GLSL:
@@ -122,7 +127,6 @@ i915_get_param(struct pipe_screen *screen, enum pipe_cap cap)
case PIPE_CAP_POINT_SPRITE:
case PIPE_CAP_SHADER_STENCIL_EXPORT:
case PIPE_CAP_TEXTURE_MIRROR_CLAMP:
- case PIPE_CAP_TEXTURE_MIRROR_REPEAT:
case PIPE_CAP_TEXTURE_SWIZZLE:
case PIPE_CAP_TIMER_QUERY:
return 0;
More information about the mesa-commit
mailing list