Mesa (master): glsl: Fix leak of LinkedTransformFeedback.Varyings.

Eric Anholt anholt at kemper.freedesktop.org
Wed Jan 18 18:38:00 UTC 2012


Module: Mesa
Branch: master
Commit: 5a0f395bcf70e524492e766a07cf0b816b42a20d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5a0f395bcf70e524492e766a07cf0b816b42a20d

Author: Eric Anholt <eric at anholt.net>
Date:   Thu Jan 12 13:10:26 2012 -0800

glsl: Fix leak of LinkedTransformFeedback.Varyings.

I copy-and-pasted the thing I was allocating for as the context, so
the first time it would be NULL (root of a ralloc context) and they'd
chain off each other from then on.

NOTE: This is a candidate for the 8.0 branch.

---

 src/glsl/linker.cpp |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index 0d85aee..adedfe6 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -1984,7 +1984,7 @@ store_tfeedback_info(struct gl_context *ctx, struct gl_shader_program *prog,
       separate_attribs_mode ? num_tfeedback_decls : 1;
 
    prog->LinkedTransformFeedback.Varyings =
-      rzalloc_array(prog->LinkedTransformFeedback.Varyings,
+      rzalloc_array(prog,
 		    struct gl_transform_feedback_varying_info,
 		    num_tfeedback_decls);
 




More information about the mesa-commit mailing list