Mesa (master): i965/blorp: Simplify check that src/dst width/height match.

Paul Berry stereotype441 at kemper.freedesktop.org
Tue Jul 24 22:22:50 UTC 2012


Module: Mesa
Branch: master
Commit: da54d2e576426122009be083ecbfb9eefd8a3799
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=da54d2e576426122009be083ecbfb9eefd8a3799

Author: Paul Berry <stereotype441 at gmail.com>
Date:   Fri Jul 13 18:30:55 2012 -0700

i965/blorp: Simplify check that src/dst width/height match.

When checking that the source and destination dimensions match, we
don't need to store the width and height in variables; doing so just
risks confusion since right after the check, we do clipping and
scissoring, which may alter the width and height.

No functional change.

Reviewed-by: Chad Versace <chad.versace at linux.intel.com>

---

 src/mesa/drivers/dri/i965/brw_blorp_blit.cpp |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
index f72145f..eb79359 100644
--- a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
+++ b/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp
@@ -191,10 +191,8 @@ try_blorp_blit(struct intel_context *intel,
    fixup_mirroring(mirror_y, dstY0, dstY1);
 
    /* Make sure width and height match */
-   GLsizei width = srcX1 - srcX0;
-   GLsizei height = srcY1 - srcY0;
-   if (width != dstX1 - dstX0) return false;
-   if (height != dstY1 - dstY0) return false;
+   if (srcX1 - srcX0 != dstX1 - dstX0) return false;
+   if (srcY1 - srcY0 != dstY1 - dstY0) return false;
 
    /* If the destination rectangle needs to be clipped or scissored, do so.
     */




More information about the mesa-commit mailing list