Mesa (8.0): 27 new commits
Ian Romanick
idr at kemper.freedesktop.org
Wed Oct 24 18:41:25 UTC 2012
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=47a509c0461e1bfb37a5d0ec0ef4bc65150221e1
Author: Brian Paul <brianp at vmware.com>
Date: Sat Sep 22 09:30:23 2012 -0600
mesa: fix incorrect error for glCompressedSubTexImage
If a subtexture region isn't aligned to the compressed block size,
return GL_INVALID_OPERATION, not gl_INVALID_VALUE.
NOTE: This is a candidate for the stable branches.
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit 1f586684d62c4f5208d1f3929d067a79ea2140ac)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=59b1e4a29e756d291f815d4429c8af0e4cf068aa
Author: Brian Paul <brianp at vmware.com>
Date: Sat Sep 8 09:27:46 2012 -0600
mesa: do internal format error checking for glTexStorage()
Turns out we weren't doing any format checking before. Now check
the internal format and, in particular, make sure that unsized internal
formats aren't accepted.
Note: This is a candidate for the stable branches.
(cherry picked from commit 2e4fc54977977e674ee77294e6632a24e594d17f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9afcb18146c457a789266eafa8596c96445d7c5e
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Sep 26 11:08:11 2012 -0700
dri_util: Use calloc to allocate __DRIcontext
The __DRIcontext contains some pointers, and some drivers check for them to be
NULL in some failure paths. Instead of sprinkling NULL assignments across the
various drivers, just zero out the whole thing.
NOTE: This is a candidate for the 9.0 branch.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-and-tested-by: Kenneth Graunke <kenneth at whitecape.org>
Tested-by: Lu Hua <huax.lu at intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53618
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54301
(cherry picked from commit f93cb0bebb10e3e3e5df099be51021b211650356)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c4b61e0c226e57533e0f7362cffde0e05cc89f4
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Tue Sep 18 15:19:18 2012 +0200
mesa: Allow glGetTexParameter of GL_TEXTURE_SRGB_DECODE_EXT
This was already (correctly) supported for glGetSamplerParameter paths.
NOTE: This is a candidate for stable branches.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit ae3023e9675a033ff66b9bb14598aa1f02530d7f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b130d42279419674cb5aecf321e1650d4f46419b
Author: Chris Forbes <chrisf at ijw.co.nz>
Date: Sun Sep 16 19:54:11 2012 +1200
mesa: fix dropped && in glGetStringi()
This fixes glGetStringi(GL_EXTENSIONS,.. for core contexts. Previously,
all extension names returned would be NULL.
NOTE: This is a candidate for release branches.
Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit d30a7d2eb4b6d853bfa90169341334f2b2a643d5)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f0b188a6c67ed1b78d69d27d772f1d7c3069c954
Author: Eric Anholt <eric at anholt.net>
Date: Mon Aug 6 14:59:39 2012 -0700
i965: Drop the confusing saturate argument to math instruction setup.
This was ridiculous. We were ignoring the inst->header.saturate flag in the
case of math and only math. On gen4, we would leave inst->header.saturate in
place if it happened to be set, which would end up being applied to the
implicit mov and thus trash the first argument. On gen6, we would overwrite
inst->header.saturate with the saturate flag from the argument, which was not
set appropriately in brw_vec4_emit.cpp, and was only not a bug due to our
incompetence at coalescing saturate moves.
By ripping the argument out and making saturate work just like all the other
brw_eu_emit.c code generation, we can avoid both these classes of bugs.
Fixes piglit fog-modes, and the new specific fs-saturate-exp2 case.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=48628
NOTE: This is a candidate for the 8.0 branch.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 9b4053cabd8bda180b352d2d2047209f6ca5f6e8)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7a139205975569630586c73522c7e934d0cae937
Author: Eric Anholt <eric at anholt.net>
Date: Mon Aug 6 08:26:30 2012 -0700
mesa: In conditional rendering fallback, check the query status.
Otherwise, conditional rendering always takes the fallthrough "render it
anyway" case unless the application had itself done a check or wait on the
query.
Fixes intel oglconform's conditional_render advanced.nofbo.readpixels.
Reviewed-by: Brian Paul <brianp at vmware.com>
NOTE: This is a candidate for the 8.0 branch.
(cherry picked from commit 1b148e660e4cefcfbdc65ef8a58a7e52e8820782)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bd9f729091bbbce521d4526afd0230da2a7cf350
Author: Eric Anholt <eric at anholt.net>
Date: Wed Aug 1 12:38:56 2012 -0700
mesa: Fix glPopAttrib() behavior on GL_FRAMEBUFFER_SRGB.
I happened to notice this while looking at a blit pass in l4d2, which had an
optional push/pop around framebuffer srgb setting. It didn't matter in the
end, but the fix is sitting in my tree now.
Reviewed-by: Brian Paul <brianp at vmware.com>
NOTE: This is a candidate for the 8.0 branch.
(cherry picked from commit 4bbd12036819ed6a2d0993c437e0c02bf0c92b0b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6fc0ebb44ac7b2119f028608123e29f2ea8285a9
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Aug 31 01:00:15 2012 -0700
i965/fs: Don't use brw->fragment_program in calculate_urb_setup().
Reading brw->fragment_program is nonsensical in compiler code: it
contains the currently active program (if any), not the one currently
being compiled. Attempting to access it may either lead to crashes
(null pointer dereference if no program is active) or wrong results.
Fixes piglit regressions since 9ef710575b914ddfc8e9a162d98ad554c1c217f7
on pre-Sandybridge hardware. The actual bug was created in commit
7b1fbc688999fd568e65211d79d7678562061594.
NOTE: This is a candidate for the 9.0 and 8.0 branches.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=54183
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
Reviewed-by: Paul Berry <stereotype441 at gmail.com>
(cherry picked from commit 4d9abd96cc177cade79b64544096eb45bf8313a2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=81627c7d45df1618413ac5c5149587dd7840526d
Author: Brian Paul <brianp at vmware.com>
Date: Thu Aug 30 16:12:53 2012 -0600
st/mesa: s/CALLOC/calloc/ to fix allocation bug
The CALLOC() macro only takes one argument so this was being treated
as a comma expression. Simply use calloc() instead.
A follow-on patch will replace all CALLOC() calls with calloc().
NOTE: This is a candidate for the 8.0 and 9.0 branches.
(cherry picked from commit 43ed822a50db6b980041ddf91c16c7f8fccc4092)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2b9a0c743a516e6754305bd8bf1bcf5ee8757c78
Author: Eric Anholt <eric at anholt.net>
Date: Sun Aug 12 23:30:18 2012 -0700
i965: Fix accumulator_contains() test to also reject swizzles of the dst.
When faced with this sequence:
MOV R1, c[1];
MAD R0, R2, R1.x, R1.y;
we were concluding that the MOV of R1 set up our accumulator and so we could
just use the previous result. Only, it's got R1.xyzw in it instead of the
r1.y we're looking for.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=46784
NOTE: This is a candidate for the 8.0 branch.
(cherry picked from commit 6754ec831e5aaec516db929c8db6e7478a2f5540)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=bb2fa7ef06fd79be9f958d8b94bc87093eece655
Author: Stéphane Marchesin <marcheu at chromium.org>
Date: Tue Aug 14 17:15:54 2012 -0700
glsl/linker: Avoid buffer over-run in parcel_out_uniform_storage::visit_field
When too may uniforms are used, the error will be caught in
check_resources (src/glsl/linker.cpp).
NOTE: This is a candidate for the 8.0 branch.
Signed-off-by: Stéphane Marchesin <marcheu at chromium.org>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
Tested-by: Benoit Jacob <bjacob at mozilla.com>
(cherry picked from commit ff996cafce511dd8a6c4e066e409c23e147a670c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b75d5c671f95116c61c44729b04db19b076e9cfc
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Jul 26 18:46:23 2012 -0700
mesa/es: Validate glTexImage border in Mesa code rather than the ES wrapper
Also validate glCopyTexImage border. This fixes a bug in the APIspec.
Previously glTexImage3DOES could be passed a non-zero border without error.
NOTE: This is a candidate for stable release branches.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
(cherry picked from commit 0686ccac950bac1a650400b29c47ddaafea22fa9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7e7f7a32c2d84c15033ab7e02500edf92664cf47
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Jul 26 18:43:26 2012 -0700
mesa: Generate an error when glCopyTexImage border is invalid
NOTE: This is a candidate for stable release branches.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>
(cherry picked from commit 59d965333c05534475b60042571366656b97ab9d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=93aa04bc8275d109dcb3001f3d0f66cacb9a6589
Author: Brian Paul <brianp at vmware.com>
Date: Fri Aug 10 10:36:17 2012 -0600
mesa: raise GL_INVALID_OPERATION in glGenerateMipmap for missing base image
This seems to be expected by the WebGL texture-mips test. The error makes
sense, but I haven't found (yet) any OpenGL documentation specifying this
error condition.
See http://bugs.freedesktop.org/show_bug.cgi?id=44912
Note: This is a candidate for the 8.0 branch.
Reviewed-by: José Fonseca <jfonseca at vmware.com>
(cherry picked from commit f6b7157550205a0633b4c2cb49a807d581176e21)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=64330801bb6d66bb9cf0dfb096c04717f41fcbfc
Author: Niels Ole Salscheider <niels_ole at salscheider-online.de>
Date: Sun Aug 12 18:35:10 2012 +0200
st/mesa: index can be negative in the PROGRAM_CONSTANT case
NOTE: This is a candidate for the 8.0 branch.
Reviewed-by: Brian Paul <brianp at vmware.com>
(cherry picked from commit 8cc1860d4a55c93ce12a649c281012b37212ffbd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0504ee8f354be331ebaf9267b26ae1743c95ed3f
Author: Marek Olšák <maraeo at gmail.com>
Date: Sun Aug 5 02:46:41 2012 +0200
gallium/u_blit: set dst format from pipe_resource, not pipe_surface
We use it to decide whether we can use resource_copy_region.
NOTE: This is a candidate for the 8.0 branch.
(cherry picked from commit b7c4ee21c53a73d84e352d6f3db2547f6434d14e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d98eb4b2f0ce93ee43ebdf954234509282497e4d
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Fri Aug 10 10:26:03 2012 -0700
intel: Move finish_batch() call before MI_BATCH_BUFFER_END and padding.
On Gen4+, brw_finish_batch() calls brw_emit_query_end(), which emits
some extra PIPE_CONTROLs to capture the current occlusion query data.
Unfortunately, it was being called *after* _intel_batchbuffer_flush
added the MI_BATCH_BUFFER_END, meaning those PIPE_CONTROLs didn't get
inside the batch.
Not only does this likely cause bogus occlusion query values, it can
also cause crashes: with the recent change to use 64-bit depth count
writes on Gen6+, we started emitting an odd-length PIPE_CONTROL, which
happened after the MI_NOOP padding. This resulted in an odd-length
batch buffer, which resulted in execbuf2 returning -EINVAL and the
application dying with an intel_do_flush_locked failure.
On older generations, finish_batch() doesn't emit any state, so this
change shouldn't have any effect.
Huge thanks to Chris Wilson for helping me figure this out.
NOTE: This is a candidate for stable release branches.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=53311
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit 9da50667f490ba2c6240f4c91c9707e3f181adae)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=620a1f973be89b35b11fbf074451601a05b621b6
Author: Brian Paul <brianp at vmware.com>
Date: Fri Aug 10 12:16:10 2012 -0600
softpipe: fix softpipe_delete_fs_state() failed assertion
The var!=softpipe->fs_variant assertion was failing because we weren't
nulling the softpipe->fs_variant pointer when binding a new shader.
Since softpipe->fs_variant depends on the current fs, it's of no use
when a new FS is bound.
Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53318
Note: This is a candidate for the 8.0 branch.
Reviewed-by: José Fonseca <jfonseca at vmware.com>
(cherry picked from commit 16c702ef3b9cff320c2adbfa853e00088adbf689)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b28f4a0abd6bf5a5f023a7a37bd1b43dff1995bb
Author: Brian Paul <brianp at vmware.com>
Date: Fri Aug 10 09:57:05 2012 -0600
st/mesa: fix renderbuffer validation bug
After we attach a new renderbuffer in this function we need to make
sure Mesa's update_framebuffer() gets called.
Fixes crash in WebGL conformance/textures/texture-attachment-formats.html,
but the test still fails for other reasons.
Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53316
Note: This is a candidate for the 8.0 branch.
Reviewed-by: José Fonseca <jfonseca at vmware.com>
(cherry picked from commit cf77c29e6015d177c046adee3c48589cc9fb5015)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1417f429049c32e9e27dba92f230992bcf2d8a92
Author: Brian Paul <brianp at vmware.com>
Date: Fri Aug 10 09:23:36 2012 -0600
gallivm: fix crash in lp_sampler_static_state()
Fixes WebGL conformance/uniforms/uniform-default-values.html crash.
We need to check for the null view pointer before accessing view->texture.
Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53317
Note: This is a candidate for the 8.0 branch.
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
(cherry picked from commit f7af4beae5e25c060d4f2c53d55b0e87ee9bdaeb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=570b551a7607df0d246c9e21ebe9f880d142fbb1
Author: Brian Paul <brianp at vmware.com>
Date: Fri Aug 10 09:12:50 2012 -0600
st/mesa: fix glCopyTexSubImage crash
Fixes a WebGL crash. The dest texture image is at level 2 and is of
size 1x1 texel. The st texture image is a stand-alone resource, not
a pointer into a complete mipmap. So the resource has one level and
trying to write to level 2 blows up.
Fixes http://bugs.freedesktop.org/show_bug.cgi?id=53314
and http://bugs.freedesktop.org/show_bug.cgi?id=53319
Note: This is a candidate for the 8.0 branch.
Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
(cherry picked from commit 9b04abe36812a34ba447e5b1f8d8e44a10510820)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=563d73a57dcdc46a1af7bf26e7890bbfa6f1340e
Author: Eric Anholt <eric at anholt.net>
Date: Fri Jul 27 15:57:07 2012 -0700
i965/vs: Convert EdgeFlagPointer values appropriately for the VS on gen4.
Fixes piglit gl-2.0/edgeflag.
NOTE: This is a candidate for the 8.0 branch.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit b3367f56d880550befb31a0100c448e1d607915f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8ab1f2e4106ee0a332f83bbcf54de6136ed63fe
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Wed Jul 18 14:26:24 2012 -0700
dri2: Fix bug in attribute handling for non-desktop OpenGL contexts
Previously an error would be generated if any attributes were specified when
creating a non-desktop OpenGL context. This was a mistake, and it will
prevent old drivers from working with new EGL libraries that add support for
the createContextAttribs interface. Instead, match the behavior of
EGL_KHR_create_context: allow versions that make sense, reject non-zero flags.
NOTE: This is a candidate for the 8.0 branch.
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Cc: Kristian Høgsberg <krh at bitplanet.net>
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
(cherry picked from commit 63adb6b9eaa723f6bf9603f3f567e04451df857e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4e53cb22c6fe7b10d70cf40b1a8cf75d0a657750
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Sat Aug 4 21:28:23 2012 -0700
i965/vs: Don't clobber sampler message MRFs with subexpressions.
See the preceding commit for a description of the problem.
NOTE: This is a candidate for stable release branches.
v2: Use a separate dPdx variable rather than reusing the lod src_reg.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52129
Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit 54c045b93cd205bcf031e70d65238d60bfc07da4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3053b30ddddcddd01705986d2a342f221a41174c
Author: Chad Versace <chad.versace at linux.intel.com>
Date: Fri Jan 27 16:44:26 2012 -0800
swrast: Fix implicit declaration warnings
In a recent commit,
commit 1c0f1dd42a50464eeb81de4aad8eecf24b3d6c89
Author: Chad Versace <chad.versace at linux.intel.com>
swrast: Fix fixed-function fragment processing
I defined a new function,_swrast_fragment_program, but neglected
to #include s_fragprog.h for clients of that function.
Note: This is a candidate for the 8.0 branch.
Reported-by: Brian Paul <brianp at vmware.com>
Signed-off-by: Chad Versace <chad.versace at linux.intel.com>
(cherry picked from commit ab1195cf1127781909d5158c7de68f8732458d75)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=464263d61325d8b3e79ebb89cedc9c7431d4ef9e
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Fri Oct 19 14:04:08 2012 -0700
i965: Fix regression in depth texture rendering on pre-SNB
This was introduced by commit 24db6d6 (cherry-picked from a683012). The
original patch fixed potential GPU hangs on SNB, and it caused some
rendering regressions there. The benefits outweigh the costs.
However, the work-around is not necessary for pre-SNB chipsets.
Applying the work-around there gives rendering regressions with no
benefit. This patch disables the work-around on pre-SNB chipsets.
Without the original patch, the piglit test
depthstencil-render-miplevels would reliably hang an SNB GPU. On ILK
this test would not hang, and it does not hang with this patch.
NOTE: This is a candidate for the 8.0 and 9.0 branches
Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
Acked-by: Kenneth Graunke <kenneth at whitecape.org>
Acked-by: Paul Berry <stereotype441 at gmail.com>
(cherry picked from commit 5fe5aa8e55a8db0b80f6ff9838bad47ce0406fd0)
More information about the mesa-commit
mailing list