Mesa (master): postprocess: Check ppq is null before calling pp_free_bos.
Vinson Lee
vlee at kemper.freedesktop.org
Tue Aug 6 00:29:31 UTC 2013
Module: Mesa
Branch: master
Commit: 8294d969e1c2154721eb34dff5848b64f4604308
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=8294d969e1c2154721eb34dff5848b64f4604308
Author: Vinson Lee <vlee at freedesktop.org>
Date: Fri Aug 2 23:39:24 2013 -0700
postprocess: Check ppq is null before calling pp_free_bos.
pp_free_bos dereferences ppq without a null check.
Fixes "Dereference before null check" defect reported by Coverity.
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>
---
src/gallium/auxiliary/postprocess/pp_init.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/src/gallium/auxiliary/postprocess/pp_init.c b/src/gallium/auxiliary/postprocess/pp_init.c
index 201a357..a49a23d 100644
--- a/src/gallium/auxiliary/postprocess/pp_init.c
+++ b/src/gallium/auxiliary/postprocess/pp_init.c
@@ -169,7 +169,9 @@ pp_free(struct pp_queue_t *ppq)
{
unsigned int i, j;
- pp_free_fbos(ppq);
+ if (ppq) {
+ pp_free_fbos(ppq);
+ }
if (ppq && ppq->p) {
if (ppq->p->pipe && ppq->filters && ppq->shaders) {
More information about the mesa-commit
mailing list