Mesa (master): draw: Change slot from unsigned to int.

Vinson Lee vlee at kemper.freedesktop.org
Tue Aug 6 00:40:39 UTC 2013


Module: Mesa
Branch: master
Commit: 8e850f2febd7b37485675e58e31221fc71080dd4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e850f2febd7b37485675e58e31221fc71080dd4

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Mon Aug  5 17:33:51 2013 -0700

draw: Change slot from unsigned to int.

unfilled_stage::face_slot is of type int.

Fixes "Unsigned compared against 0" defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Brian Paul <brianp at vmware.com>

---

 src/gallium/auxiliary/draw/draw_pipe_unfilled.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
index c6ee95c..68bab72 100644
--- a/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
+++ b/src/gallium/auxiliary/draw/draw_pipe_unfilled.c
@@ -67,7 +67,7 @@ inject_front_face_info(struct draw_stage *stage,
    boolean is_front_face = (
       (stage->draw->rasterizer->front_ccw && ccw) ||
       (!stage->draw->rasterizer->front_ccw && !ccw));
-   unsigned slot = unfilled->face_slot;
+   int slot = unfilled->face_slot;
    unsigned i;
 
    /* In case the backend doesn't care about it */




More information about the mesa-commit mailing list