Mesa (master): svga: remove no-op checks in sampler, sampler_view functions

Brian Paul brianp at kemper.freedesktop.org
Fri Apr 4 02:07:02 UTC 2014


Module: Mesa
Branch: master
Commit: 4105ad825f5367fb630631bf13308bf809c17926
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4105ad825f5367fb630631bf13308bf809c17926

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Apr  2 17:12:20 2014 -0600

svga: remove no-op checks in sampler, sampler_view functions

We are checking for no-ops in the CSO module for both of these items
so there's no reason to do it in the driver.

Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Reviewed-by: José Fonseca <jfonseca at vmware.com>

---

 src/gallium/drivers/svga/svga_pipe_sampler.c |   15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_pipe_sampler.c b/src/gallium/drivers/svga/svga_pipe_sampler.c
index a5b5d00..8a87bb4 100644
--- a/src/gallium/drivers/svga/svga_pipe_sampler.c
+++ b/src/gallium/drivers/svga/svga_pipe_sampler.c
@@ -165,13 +165,6 @@ svga_bind_sampler_states(struct pipe_context *pipe,
    if (shader != PIPE_SHADER_FRAGMENT)
       return;
 
-   /* Check for no-op */
-   if (start + num <= svga->curr.num_samplers &&
-       !memcmp(svga->curr.sampler + start, samplers, num * sizeof(void *))) {
-      if (0) debug_printf("sampler noop\n");
-      return;
-   }
-
    for (i = 0; i < num; i++)
       svga->curr.sampler[start + i] = samplers[i];
 
@@ -240,14 +233,6 @@ svga_set_sampler_views(struct pipe_context *pipe,
    if (shader != PIPE_SHADER_FRAGMENT)
       return;
 
-   /* Check for no-op */
-   if (start + num <= svga->curr.num_sampler_views &&
-       !memcmp(svga->curr.sampler_views + start, views,
-               num * sizeof(struct pipe_sampler_view *))) {
-      if (0) debug_printf("texture noop\n");
-      return;
-   }
-
    for (i = 0; i < num; i++) {
       if (svga->curr.sampler_views[start + i] != views[i]) {
          /* Note: we're using pipe_sampler_view_release() here to work around




More information about the mesa-commit mailing list