Mesa (master): llvmpipe: remove no-op checks in sampler, sampler_view functions

Brian Paul brianp at kemper.freedesktop.org
Fri Apr 4 02:07:02 UTC 2014


Module: Mesa
Branch: master
Commit: 177c9be61535a66607e0de9b0ecf00c8d5d451ac
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=177c9be61535a66607e0de9b0ecf00c8d5d451ac

Author: Brian Paul <brianp at vmware.com>
Date:   Wed Apr  2 17:15:47 2014 -0600

llvmpipe: remove no-op checks in sampler, sampler_view functions

Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Reviewed-by: José Fonseca <jfonseca at vmware.com>

---

 src/gallium/drivers/llvmpipe/lp_state_sampler.c |   14 --------------
 1 file changed, 14 deletions(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_state_sampler.c b/src/gallium/drivers/llvmpipe/lp_state_sampler.c
index db8646c..09bc928 100644
--- a/src/gallium/drivers/llvmpipe/lp_state_sampler.c
+++ b/src/gallium/drivers/llvmpipe/lp_state_sampler.c
@@ -77,13 +77,6 @@ llvmpipe_bind_sampler_states(struct pipe_context *pipe,
    assert(shader < PIPE_SHADER_TYPES);
    assert(start + num <= Elements(llvmpipe->samplers[shader]));
 
-   /* Check for no-op */
-   if (start + num <= llvmpipe->num_samplers[shader] &&
-       !memcmp(llvmpipe->samplers[shader] + start, samplers,
-               num * sizeof(void *))) {
-      return;
-   }
-
    draw_flush(llvmpipe->draw);
 
    /* set the new samplers */
@@ -125,13 +118,6 @@ llvmpipe_set_sampler_views(struct pipe_context *pipe,
    assert(shader < PIPE_SHADER_TYPES);
    assert(start + num <= Elements(llvmpipe->sampler_views[shader]));
 
-   /* Check for no-op */
-   if (start + num <= llvmpipe->num_sampler_views[shader] &&
-       !memcmp(llvmpipe->sampler_views[shader] + start, views,
-               num * sizeof(struct pipe_sampler_view *))) {
-      return;
-   }
-
    draw_flush(llvmpipe->draw);
 
    /* set the new sampler views */




More information about the mesa-commit mailing list