Mesa (master): meta: Do power of two samples check only for samples > 0

Anuj Phogat aphogat at kemper.freedesktop.org
Wed Feb 25 22:25:44 UTC 2015


Module: Mesa
Branch: master
Commit: 0a4ea87344a1cbca4c50cfca1efe97202aa18be8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0a4ea87344a1cbca4c50cfca1efe97202aa18be8

Author: Anuj Phogat <anuj.phogat at gmail.com>
Date:   Sun Dec 31 16:05:42 2000 -0800

meta: Do power of two samples check only for samples > 0

otherwise samples=0 passes the check, which is invalid.

Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Neil Roberts <neil at linux.intel.com>

---

 src/mesa/drivers/common/meta_blit.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c
index 3406be1..971a2ff 100644
--- a/src/mesa/drivers/common/meta_blit.c
+++ b/src/mesa/drivers/common/meta_blit.c
@@ -82,7 +82,7 @@ setup_glsl_msaa_blit_scaled_shader(struct gl_context *ctx,
    y_scale = samples * 0.5;
 
    /* We expect only power of 2 samples in source multisample buffer. */
-   assert((samples & (samples - 1)) == 0);
+   assert(samples > 0 && (samples & (samples - 1)) == 0);
    while (samples >> (shader_offset + 1)) {
       shader_offset++;
    }
@@ -261,7 +261,7 @@ setup_glsl_msaa_blit_shader(struct gl_context *ctx,
    }
 
    /* We expect only power of 2 samples in source multisample buffer. */
-   assert((samples & (samples - 1)) == 0);
+   assert(samples > 0 && (samples & (samples - 1)) == 0);
    while (samples >> (shader_offset + 1)) {
       shader_offset++;
    }




More information about the mesa-commit mailing list