Mesa (master): mesa: Correct backwards NULL check.

Matt Turner mattst88 at kemper.freedesktop.org
Mon Mar 2 18:28:43 UTC 2015


Module: Mesa
Branch: master
Commit: 491d42135ad0e5670756216154f2ba9fc79d4ba7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=491d42135ad0e5670756216154f2ba9fc79d4ba7

Author: Matt Turner <mattst88 at gmail.com>
Date:   Sat Feb 28 11:14:02 2015 -0800

mesa: Correct backwards NULL check.

Cc: "10.4, 10.5" <mesa-stable at lists.freedesktop.org>
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

---

 src/mesa/main/shaderapi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c
index dd536cd..5731d58 100644
--- a/src/mesa/main/shaderapi.c
+++ b/src/mesa/main/shaderapi.c
@@ -1739,7 +1739,7 @@ _mesa_GetProgramBinary(GLuint program, GLsizei bufSize, GLsizei *length,
     * Ensure that length always points to valid storage to avoid multiple NULL
     * pointer checks below.
     */
-   if (length != NULL)
+   if (length == NULL)
       length = &length_dummy;
 
 




More information about the mesa-commit mailing list