Mesa (master): i965: Consider scratch writes to have side effects.

Matt Turner mattst88 at kemper.freedesktop.org
Mon Mar 2 18:28:43 UTC 2015


Module: Mesa
Branch: master
Commit: da20bf068ef0f816968d9bc4dfea81facf0fd680
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=da20bf068ef0f816968d9bc4dfea81facf0fd680

Author: Matt Turner <mattst88 at gmail.com>
Date:   Sat Feb 28 13:36:21 2015 -0800

i965: Consider scratch writes to have side effects.

We could do better by tracking scratch reads and writes.

Cc: 10.5 <mesa-stable at lists.freedesktop.org>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88793
Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

---

 src/mesa/drivers/dri/i965/brw_shader.cpp |    1 +
 1 file changed, 1 insertion(+)

diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
index fbb20bc..ec3cfcb 100644
--- a/src/mesa/drivers/dri/i965/brw_shader.cpp
+++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
@@ -963,6 +963,7 @@ backend_instruction::has_side_effects() const
 {
    switch (opcode) {
    case SHADER_OPCODE_UNTYPED_ATOMIC:
+   case SHADER_OPCODE_GEN4_SCRATCH_WRITE:
    case SHADER_OPCODE_URB_WRITE_SIMD8:
    case FS_OPCODE_FB_WRITE:
       return true;




More information about the mesa-commit mailing list