Mesa (master): freedreno/ir3: fix silly typo for binning pass shaders

Rob Clark robclark at kemper.freedesktop.org
Thu Mar 5 20:36:52 UTC 2015


Module: Mesa
Branch: master
Commit: 60096ed906e5ebfdce41024c7af69f03b96dbe82
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=60096ed906e5ebfdce41024c7af69f03b96dbe82

Author: Rob Clark <robclark at freedesktop.org>
Date:   Thu Mar  5 15:27:27 2015 -0500

freedreno/ir3: fix silly typo for binning pass shaders

Was resulting in gl_PointSize write being optimized out, causing
particle system type shaders to hang if hw binning enabled.

Fixes neverball, OGLES2ParticleSystem, etc.

Signed-off-by: Rob Clark <robclark at freedesktop.org>

---

 src/gallium/drivers/freedreno/ir3/ir3_compiler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/freedreno/ir3/ir3_compiler.c b/src/gallium/drivers/freedreno/ir3/ir3_compiler.c
index 2084ad3..fb51cde 100644
--- a/src/gallium/drivers/freedreno/ir3/ir3_compiler.c
+++ b/src/gallium/drivers/freedreno/ir3/ir3_compiler.c
@@ -3337,7 +3337,7 @@ ir3_compile_shader(struct ir3_shader_variant *so,
 	if (key.binning_pass) {
 		for (i = 0, j = 0; i < so->outputs_count; i++) {
 			unsigned name = sem2name(so->outputs[i].semantic);
-			unsigned idx = sem2name(so->outputs[i].semantic);
+			unsigned idx = sem2idx(so->outputs[i].semantic);
 
 			/* throw away everything but first position/psize */
 			if ((idx == 0) && ((name == TGSI_SEMANTIC_POSITION) ||




More information about the mesa-commit mailing list