Mesa (master): nvc0: do not force re-binding of compute constbufs on Fermi
Samuel Pitoiset
hakzsam at kemper.freedesktop.org
Mon Jan 11 23:49:09 UTC 2016
Module: Mesa
Branch: master
Commit: e67f5cac796de5bce1081d723ade711a4f215f98
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e67f5cac796de5bce1081d723ade711a4f215f98
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Jan 12 00:31:11 2016 +0100
nvc0: do not force re-binding of compute constbufs on Fermi
Re-binding compute constant buffers after launching a grid have no effects
because they are not currently validated and because dirty_cp is not updated
accordingly. This might also prevent weird future behaviours when UBOs will
be bound for compute.
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
---
src/gallium/drivers/nouveau/nvc0/nvc0_compute.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
index 9d4606f..7180434 100644
--- a/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
+++ b/src/gallium/drivers/nouveau/nvc0/nvc0_compute.c
@@ -248,7 +248,7 @@ nvc0_launch_grid(struct pipe_context *pipe,
/* rebind all the 3D constant buffers
* (looks like binding a CB on COMPUTE clobbers 3D state) */
nvc0->dirty |= NVC0_NEW_CONSTBUF;
- for (s = 0; s < 6; s++) {
+ for (s = 0; s < 5; s++) {
for (i = 0; i < NVC0_MAX_PIPE_CONSTBUFS; i++)
if (nvc0->constbuf[s][i].u.buf)
nvc0->constbuf_dirty[s] |= 1 << i;
More information about the mesa-commit
mailing list