Mesa (master): vc4: Don't record the seqno of a failed job submit.

Eric Anholt anholt at kemper.freedesktop.org
Thu Jan 28 04:28:01 UTC 2016


Module: Mesa
Branch: master
Commit: 2a449ce7c961f3269f9a37ddf4fe340fc170c609
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a449ce7c961f3269f9a37ddf4fe340fc170c609

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Jan 26 10:28:45 2016 -0800

vc4: Don't record the seqno of a failed job submit.

On an error return, the returned seqno will probably be unset, so we'd
lose track of what we've submitted so far for waiting on in the
future.

Cc: "11.0 11.1" <mesa-stable at lists.freedesktop.org>
Signed-off-by: Eric Anholt <eric at anholt.net>

---

 src/gallium/drivers/vc4/vc4_job.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/vc4/vc4_job.c b/src/gallium/drivers/vc4/vc4_job.c
index 5d071ec..e7b52e3 100644
--- a/src/gallium/drivers/vc4/vc4_job.c
+++ b/src/gallium/drivers/vc4/vc4_job.c
@@ -245,11 +245,11 @@ vc4_job_submit(struct vc4_context *vc4)
                         fprintf(stderr, "Draw call returned %s.  "
                                         "Expect corruption.\n", strerror(errno));
                         warned = true;
+                } else if (!ret) {
+                        vc4->last_emit_seqno = submit.seqno;
                 }
         }
 
-        vc4->last_emit_seqno = submit.seqno;
-
         if (vc4_debug & VC4_DEBUG_ALWAYS_SYNC) {
                 if (!vc4_wait_seqno(vc4->screen, vc4->last_emit_seqno,
                                     PIPE_TIMEOUT_INFINITE, "sync")) {




More information about the mesa-commit mailing list