Mesa (master): i965: Delete bogus assertion in emit_gs_input_load().

Kenneth Graunke kwg at kemper.freedesktop.org
Thu May 12 08:07:10 UTC 2016


Module: Mesa
Branch: master
Commit: 3aa542c65760c7e9b92a41d850677a44879cc5c7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3aa542c65760c7e9b92a41d850677a44879cc5c7

Author: Kenneth Graunke <kenneth at whitecape.org>
Date:   Sun May  8 21:23:18 2016 -0700

i965: Delete bogus assertion in emit_gs_input_load().

This looks like leftover cruft from an earlier attempt at writing
point size hacks.  Each vertex has its own copy of gl_PointSize,
so accessing any vertex other than 0 would cause this to fail.

The tests seem to work fine without it.

Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

---

 src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
index 75479ba..4648c58 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
@@ -1991,7 +1991,6 @@ fs_visitor::emit_gs_input_load(const fs_reg &dst,
       /* This input was pushed into registers. */
       if (is_point_size) {
          /* gl_PointSize comes in .w */
-         assert(imm_offset == 0);
          bld.MOV(dst, fs_reg(ATTR, imm_offset + 3, dst.type));
       } else {
          for (unsigned i = 0; i < num_components; i++) {




More information about the mesa-commit mailing list