Mesa (master): i965: fix disk_cache leak when destroying context

Tapani Pälli tpalli at kemper.freedesktop.org
Mon Jan 29 06:15:00 UTC 2018


Module: Mesa
Branch: master
Commit: b99c88037bf64b033579f237ec287857c53b0ad6
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b99c88037bf64b033579f237ec287857c53b0ad6

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Fri Jan 26 10:47:31 2018 +0200

i965: fix disk_cache leak when destroying context

   ==2780== 1,024 bytes in 1 blocks are possibly lost in loss record 180 of 205
   ==2780==    at 0x4C31A1E: calloc (vg_replace_malloc.c:711)
   ==2780==    by 0x13F6467E: util_queue_init (u_queue.c:309)
   ==2780==    by 0x13F5C9F6: disk_cache_create (disk_cache.c:369)
   ==2780==    by 0x13F05406: brw_disk_cache_init (brw_disk_cache.c:428)
   ==2780==    by 0x13F01E78: brwCreateContext (brw_context.c:1068)

Fixes: 1a61a8b9a7c ("i965: Initialize disk shader cache if MESA_GLSL_CACHE_DISABLE is false")
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Reviewed-by: Jordan Justen <jordan.l.justen at intel.com>

---

 src/mesa/drivers/dri/i965/brw_context.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c
index 9ed8bc64bb..07a234b367 100644
--- a/src/mesa/drivers/dri/i965/brw_context.c
+++ b/src/mesa/drivers/dri/i965/brw_context.c
@@ -73,6 +73,7 @@
 #include "tnl/t_pipeline.h"
 #include "util/ralloc.h"
 #include "util/debug.h"
+#include "util/disk_cache.h"
 #include "isl/isl.h"
 
 /***************************************
@@ -1129,6 +1130,8 @@ intelDestroyContext(__DRIcontext * driContextPriv)
 
    driDestroyOptionCache(&brw->optionCache);
 
+   disk_cache_destroy(brw->ctx.Cache);
+
    /* free the Mesa context */
    _mesa_free_context_data(&brw->ctx);
 




More information about the mesa-commit mailing list