Mesa (19.3): 33 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Nov 20 17:25:33 UTC 2019
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd736de7aa6e46cb52b3cc3a2b7b751f9594285b
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Wed Nov 20 09:25:03 2019 -0800
VERSION: bump for 19.3.0-rc4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b7ab6e9470d888fa541cbbae173cae4e5ade258f
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Nov 8 09:33:07 2019 -0600
anv: Stop bounds-checking pushed UBOs
The bounds checking is actually less safe than just pushing the data.
If the bounds checking actually ever kicks in and it's not on the last
UBO push range, then the shrinking will cause all subsequent ranges to
be pushed to the wrong place in the GRF. One of the behaviors we
definitely don't want is for OOB UBO access to result in completely
unrelated UBOs returning garbage values. It's safer to just push the
UBOs as-requested. If we're really concerned about robustness, we can
emit shader code to do bounds checking which should be stupid cheap (a
CMP followed by SEL).
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=addf63dbd796fc08e06ac1323071a8f8f48ac7b9
Author: Brian Paul <brianp at vmware.com>
Date: Wed Oct 9 12:05:16 2019 -0600
Call shmget() with permission 0600 instead of 0777
A security advisory (TALOS-2019-0857/CVE-2019-5068) found that
creating shared memory regions with permission mode 0777 could allow
any user to access that memory. Several Mesa drivers use shared-
memory XImages to implement back buffers for improved performance.
This path changes the shmget() calls to use 0600 (user r/w).
Tested with legacy Xlib driver and llvmpipe.
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit 02c3dad0f3b4d26e0faa5cc51d06bc50d693dcdc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2b4459973b8429370cbe5807eb1cb33153b0ae72
Author: Rob Clark <robdclark at chromium.org>
Date: Mon Nov 18 09:42:03 2019 -0800
Revert "freedreno/ir3: enable pre-fs texture fetch for a6xx"
This reverts commit f30c256ec05618fb40dccbd94a3434b2f63db478.
See 088a2a4cab031f1505d531698109f330f94f3072
Fixes: f30c256ec05 ("freedreno/ir3: enable pre-fs texture fetch for a6xx")
Signed-off-by: Rob Clark <robdclark at chromium.org>
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=48f8f0edca06280d56ff97a2984e605f25d5406b
Author: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Date: Thu Nov 14 15:36:27 2019 +0200
i965: Unify CC_STATE and BLEND_STATE atoms on Haswell as a workaround
Re-emitting 3DSTATE_CC_STATE_POINTERS after emitting
3DSTATE_BLEND_STATE_POINTERS fixes the shadow flickering in
SuperTuxCart and Tropico 6 which was seen only on Haswell.
The reason for this is unknown and fix was found empirically.
The closest mention in PRM is that it should improve performance.
From the HSW PRM, volume 2b, page 823 (3DSTATE_BLEND_STATE_POINTERS):
"When the BLEND_STATE pointer changes but not the CC_STATE pointer,
driver needs to force a CC_STATE pointer change to improve
blend performance in pixel backend."
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1834
Fixes: eca4a654 ("i965: Disable dual source blending when shader doesn't support it on gen8+")
Cc: <mesa-stable at lists.freedesktop.org>
Signed-off-by: Danylo Piliaiev <danylo.piliaiev at globallogic.com>
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
(cherry picked from commit 6f17fe0606a144f977d8b70a7ee9f8371abc144b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3b8461cf162e8c092fb44cff2f5e5a99ecc23112
Author: Jonathan Marek <jonathan at marek.ca>
Date: Fri Nov 15 15:34:09 2019 -0500
freedreno/registers: fix a6xx_2d_blit_cntl ROTATE
A change from b7093882 got overwritten by 610c8c93
Fixes: 610c8c93 ("freedreno/registers: Update with GS, HS and DS registers")
Signed-off-by: Jonathan Marek <jonathan at marek.ca>
Reviewed-by: Rob Clark <robdclark at gmail.com>
(cherry picked from commit 75e58d1fae94f68d75c04770b1cadc6c1b112f6c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=79610494f9d6ec925b40f558cd13e8db0d603749
Author: Jonathan Marek <jonathan at marek.ca>
Date: Fri Nov 15 12:38:28 2019 -0500
freedreno/ir3: disable texture prefetch for 1d array textures
Prefetch only supports the basic 2D texture case, checking is_array is
needed because 1d array textures pass the coord num_components==2 test.
Fixes: 2a0d45ae ("freedreno/ir3: Add a NIR pass to select tex instructions eligible for pre-fetch")
Signed-off-by: Jonathan Marek <jonathan at marek.ca>
Reviewed-by: Rob Clark <robdclark at gmail.com>
(cherry picked from commit 0f5743429c76b385db9c513102b2010213ffbb8c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=32aba91c07fd2ab05ca4ce2a05c2806d29e18435
Author: Ben Crocker <bcrocker at redhat.com>
Date: Wed Nov 13 20:27:24 2019 +0000
llvmpipe: use ppc64le/ppc64 Large code model for JIT-compiled shaders
Large programs, e.g. gnome-shell and firefox, may tax the
addressability of the Medium code model once a (potentially unbounded)
number of dynamically generated JIT-compiled shader programs are
linked in and relocated. Yet the default code model as of LLVM 8 is
Medium or even Small.
The cost of changing from Medium to Large is negligible:
- an additional 8-byte pointer stored immediately before the shader entrypoint;
- change an add-immediate (addis) instruction to a load (ld).
Testing with WebGL Conformance
(https://www.khronos.org/registry/webgl/sdk/tests/webgl-conformance-tests.html)
yields clean runs with this change (and crashes without it).
Testing with glxgears shows no detectable performance difference.
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1753327, 1753789, 1543572, 1747110, and 1582226
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/223
Co-authored by: Nemanja Ivanovic <nemanjai at ca.ibm.com>, Tom Stellard <tstellar at redhat.com>
CC: mesa-stable at lists.freedesktop.org
Signed-off-by: Ben Crocker <bcrocker at redhat.com>
(cherry picked from commit 9c3be6d21fa6a45852045d0286b80fb420f82fe3)
Conflicts resolved Dylan (PIPE_ARCH -> UTIL_ARCH rename)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=35182247fc19130a3657f8a3af8e6156caed135d
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Nov 11 14:19:51 2019 +0000
aco: fix 64-bit fsign with 0
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
(cherry picked from commit be1d11249bde1e041f6eb9c0acedb041ab450c4b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=ab4df0ec7269a1846e7cdde0c7bec051f2daf2d7
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Mon Nov 11 14:15:04 2019 +0000
aco: don't combine literals into v_cndmask_b32/v_subb/v_addc
No pipeline-db changes
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
(cherry picked from commit b062b92ab1a6504772a63a6b44f89b4579aef9a3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=37d13ecca7c33437b53be33eefcf6e66a56bddb5
Author: Dylan Baker <dylan at pnwbakers.com>
Date: Thu Nov 14 08:46:22 2019 -0800
cherry-ignore: update for 19.3.0-rc4 cycle
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a3d52fd4ab812c0041398969ea33e329a333dc0d
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 12 17:33:08 2019 +0200
Revert "dri_interface: add interface for EGL_EXT_image_flush_external"
This reverts commit 7520478461d8ab1cda415ff689d6b9058213ff43.
This series caused unexpected flickering artifacts with Iris driver on
Chrome OS and EGL_EXT_image_flush_external spec has not been published
yet.
Acked-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit 1a093a06d6b7f33b4edb621c8d1920ff69dff630)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=36fbe5b292b824844b8c21d3f12942c559138148
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 12 17:32:56 2019 +0200
Revert "st/dri: assume external consumers of back buffers can write to the buffers"
This reverts commit 1d1b4578211dcc69cfab8879d0cdafaba1eec948.
This series caused unexpected flickering artifacts with Iris driver on
Chrome OS and EGL_EXT_image_flush_external spec has not been published
yet.
Acked-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit 7951eb146c1bb57c6d2231a9675046c535530b6a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9445d96d5cce7aaa7c2b4c41735d85866da765e6
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 12 17:32:49 2019 +0200
Revert "st/dri: add support for EGL_EXT_image_flush_external"
This reverts commit 1d122c104a7a3d9348ab347e1e843b7e2bf3b498.
This series caused unexpected flickering artifacts with Iris driver on
Chrome OS and EGL_EXT_image_flush_external spec has not been published
yet.
Acked-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit 25f596e6ba4ef469fbd219aee288dd96624055eb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5cd8c67a7f86a6027aacc9c09fba391eaddc8743
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 12 17:32:41 2019 +0200
Revert "egl: handle EGL_IMAGE_EXTERNAL_FLUSH_EXT"
This reverts commit 34b1aa957a3f44ea9587ec43311e8434d3782cc1.
This series caused unexpected flickering artifacts with Iris driver on
Chrome OS and EGL_EXT_image_flush_external spec has not been published
yet.
Acked-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit ff05f16c9988d5794028dba2d437e8796be85fdd)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7c0a1d3d4732013b01cae0eb01a8e788c58f958
Author: Tapani Pälli <tapani.palli at intel.com>
Date: Tue Nov 12 17:32:33 2019 +0200
Revert "egl: implement new functions from EGL_EXT_image_flush_external"
This reverts commit c1c574fdf18f2aeb1c03f9670bf00e1dcd22d99d.
This series caused unexpected flickering artifacts with Iris driver on
Chrome OS and EGL_EXT_image_flush_external spec has not been published
yet.
Acked-by: Eric Engestrom <eric at engestrom.ch>
Acked-by: Kristian H. Kristensen <hoegsberg at google.com>
(cherry picked from commit e64b91e34aa04a137a322ae9444c1c603383c6d4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c61e5192faf16f9023ca422f627f24f5dcbb3a7
Author: Paulo Zanoni <paulo.r.zanoni at intel.com>
Date: Mon Nov 11 16:49:15 2019 -0800
intel/compiler: fix nir_op_{i,u}*32 on ICL
On ICL we have the src1 restriction which is applied through
fix_byte_src() and potentially changes the type of the operands from 8
to 32 bits. When this change happens, we fall into the "else if
(bit_size < 32)" case and miscompute src_type because it takes into
consideration bit_size (8) instead of the adjusted size of temp_op
(32). This results in the shader reading unused memory, giving us
mostly failures, but occasional passes due to whatever was already in
the registers we were reading.
This commit fixes a lot of dEQP subgroup i8vec2 tests on ICL, such as:
dEQP-VK.subgroups.arithmetic.compute.subgroupadd_i8vec2
This can also be verified by simply changing fix_byte_src() to apply
on all platforms.
Fixes: 5847de6e9afe ("intel/compiler: don't use byte operands for src1 on ICL")
Reviewed-by: Ivan Briano <ivan.briano at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni at intel.com>
(cherry picked from commit eb6352162dde1445f1fe7a408e79f4ecfdf3703c)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f393c9234544ea574ae42081e02271cf0e3588f8
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date: Tue Nov 12 10:42:09 2019 -0800
anv: Initialize depth_bounds_test_enable when not explicitly set
This was causing uninitialized value to end up propagated to the
3DSTATE_DEPTH_BOUNDS packet, leading to asserts on packet
building due to the value being greater than 1.
Fixes: 939ddccb7a5 ("anv: Add support for depth bounds testing.")
Reviewed-by: Plamena Manolova <plamena.manolova at intel.com>
(cherry picked from commit 0aaf47f7cd50b9c07c1297fe8daff1b2693a6729)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4fbe772b2376bca71a8618e17713e4379a461a96
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Oct 24 14:41:20 2019 -0700
nir/algebraic: Mark other comparison exact when removing a == a
This prevents some additional optimizations that would change the
original result. This includes things like (b < a && b < c) => b <
min(a, c) and !(a < b) => b >= a. Both of these optimizations were
specifically observed in the piglit tests added in piglit!160.
This was discovered while investigating
https://gitlab.freedesktop.org/mesa/mesa/issues/1958. However, the
problem in that issue was Chrome or Angle is replacing calls to isnan()
with some stuff that we (correctly) optimize to false. If they had left
the calls to isnan() alone, everything would have just worked.
No shader-db changes on any Intel platform.
I also tried marking the comparison generated by the isnan() function
precise. The precise marker "infects" every computation involved in
calculating the parameter to the isnan() function, and this severely
hurt all of the (few) shaders in shader-db that use isnan().
I also considered adding a new ir_unop_isnan opcode that would implement
the functionality. During GLSL IR-to-NIR translation, the resulting
comparison operation would be marked exact (and the samething would need
to happen in SPIR-V translation).
This approach taken by this patch seemed easier, but we may want to do
the ir_unop_isnan thing anyway.
Fixes: d55835b8bdf ("nir/algebraic: Add optimizations for "a == a && a CMP b"")
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>
(cherry picked from commit 9be4a422a055d1e829d56c3cc91e1fc2f6e8fb31)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=17ad67c6dcc9d910c10bd40807114b891b6636a8
Author: Ian Romanick <ian.d.romanick at intel.com>
Date: Thu Oct 24 13:41:59 2019 -0700
nir/algebraic: Add the ability to mark a replacement as exact
Reviewed-by: Matt Turner <mattst88 at gmail.com>
Reviewed-by: Connor Abbott <cwabbott0 at gmail.com>
(cherry picked from commit ea19f2fb68f54171683b6c490b2cd6df96f854c7)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=61366cdf0558b9865ca41802be0e1dffb1d6ce0c
Author: Rob Clark <robdclark at chromium.org>
Date: Fri Nov 8 12:55:27 2019 -0800
freedreno/ir3: fix gpu hang with pre-fs-tex-fetch
For pre-fs-dispatch texture fetch, we need to assign bary_ij to r0.x,
even if it is not used in the shader (ie. only varying use is for tex
coords). But if, for example, gl_FragCoord is used, it could get
assigned on top of bary_ij, resulting in a GPU hang.
The solution to this is two-fold: (1) the inputs/outputs rework has the
benefit of making RA realize bary_ij is a vec2, even if there are no
split/collect instructions (due to no varying fetches in the shader
itself). And (2) extend the live ranges of meta:input instructions to
the first non-input, to prevent RA from assigning the same register to
multiple inputs.
Backport note: because of (1) above, a better solution for 19.3 would be
to revert f30c256ec05.
Fixes: f30c256ec05 ("freedreno/ir3: enable pre-fs texture fetch for a6xx")
Signed-off-by: Rob Clark <robdclark at chromium.org>
Reviewed-by: Kristian H. Kristensen <hoegsberg at google.com>
Reviewed-by: Eric Anholt <eric at anholt.net>
(cherry picked from commit b22617fb57be54a859a8d62a5e545afcb38266e9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=001e7305abcaf0854ae0c7b9046b7c7b280af530
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Nov 12 15:53:15 2019 +0000
aco: don't propagate vgprs into v_readlane/v_writelane
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
(cherry picked from commit 2c98d79d114d3ed82a9e60519d666f51a1172cd3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b8f93550af7f86e9bec8831c3f9a42b76109e59
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Nov 12 15:44:17 2019 +0000
aco: fix read_invocation with VGPR lane index
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
(cherry picked from commit 5a1bacb6f916d9a46a3d44830a4eb4bd3dca7d23)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=992bff94f7a8f58f875191832e13bdb6b64fdfff
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Tue Nov 12 15:28:52 2019 +0000
aco: fix shuffle with uniform operands
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler')
(cherry picked from commit f97d9334263a4dd8878c4e259fb5afcdc1334904)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51a15eabe6f8dfadc79b6dc59e37e14d2939a270
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Thu Nov 7 16:22:55 2019 +0100
aco: preserve kill flag on moved operands during RA
Fixes: 93c8ebfa780ebd1495095e794731881aef29e7d3 aco: Initial commit of independent AMD compiler
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
(cherry picked from commit b6f5085dfee81d9c54fcda883d2b06742134084a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f3c0d5aa3a27a2ffd0cf4f4d1228f36dcdd3def2
Author: Daniel Schürmann <daniel at schuermann.dev>
Date: Fri Nov 8 16:36:11 2019 +0100
aco: fix invalid access on Pseudo_instructions
Fixes: 93c8ebfa780ebd1495095e794731881aef29e7d3 aco: Initial commit of independent AMD compiler
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
(cherry picked from commit a2a6880743d7370a6425593f22d9e98317bfc3b2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=512ed9899a989e85c7b12790088b24c40e3729e0
Author: Marek Olšák <marek.olsak at amd.com>
Date: Mon Nov 11 17:04:15 2019 -0500
st/mesa: fix Sanctuary and Tropics by disabling ARB_gpu_shader5 for them
They use the "sample" keyword as a variable name.
Cc: 19.2 19.3 <mesa-stable at lists.freedesktop.org>
Reviewed-by: Timothy Arceri <tarceri at itsqueeze.com>
(cherry picked from commit e00791c5525000652472cdcfe55d59f43ec3d85e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=35c196025b74d293ec494c29896ffb0f5332c245
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Jul 11 15:21:04 2019 +0300
anv/wsi: signal the semaphore in the acquireNextImage
We seem to have forgotten about the semaphore in the
acquireNextImageInfo.
v2: Signal semaphore/fence regardless of presentation status (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit edc6606d4e515707b22674a0b3357c02de52378e)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=4910128baba934a8be72a7e9ec3871d4c275896f
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Sep 20 01:24:53 2019 +0300
anv: remove list items on batch fini
This doesn't seem to fix anything because those destroy() calls happen
right before the command buffer object & its list of batch_bo is also
destroyed. Still looks a bit cleaner.
v2: Found a second occurence
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net> (v2)
Fixes: 26ba0ad54d ("vk: Re-name command buffer implementation files")
Cc: <mesa-stable at lists.freedesktop.org>
(cherry picked from commit 935f8f0e56a409b10fac86e18f68be776cdff29f)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=14c8323774a7895ac7847990078e141d2ba7be53
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Thu Aug 29 14:54:12 2019 +0300
anv: invalidate file descriptor of semaphore sync fd at vkQueueSubmit
We always close the in_fence at the end the anv_cmd_buffer_execbuf()
so when we take it from the semaphore, let's not forget to invalidate
it.
Note that the code leaks the fence_in if we get any error before
reaching the close(). Let's fix that in another patch or better,
rewrite the whole thing!
v2: drop redundant fd = -1 (Jason)
v3: Update commit message (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 048f0690ee4b39f865d4d6ad82a6c0290dcaaf41)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c78901c124a7b55d2082c6429c20f36817fad786
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Mon Nov 11 12:32:50 2019 +0200
mesa: check framebuffer completeness only after state update
The change made in 88d665830f27 ("mesa: check draw buffer completeness
on glClearBufferfi/glClearBufferiv") correctly updated the state prior
to checking the framebuffer completeness on glClearBufferiv but not in
glClearBufferfi.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>
Fixes: 88d665830f27 ("mesa: check draw buffer completeness on glClearBufferfi/glClearBufferiv")
Gitlab: https://gitlab.freedesktop.org/mesa/mesa/issues/2072
(cherry picked from commit f93bb903020bac21a36e240b2c19a4733c2405ee)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a497735ec75cfc5edaff378613e3b145b3bb22d
Author: Laurent Carlier <lordheavym at gmail.com>
Date: Wed Nov 6 16:04:50 2019 +0100
egl: avoid local modifications for eglext.h Khronos standard header file
Move differences in eglextchromium.h header file, then provide the same header than libglvnd-1.2
So program that omit to include eglextchromium.h will fail to build with both mesa and libglvnd headers.
Fixes: a0a8109f "include: add the definition of EGL_EXT_image_flush_external"
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit 57acf921e28eebb76e22f9abb96008885ec44441)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=87efb9f3a4f366372bc873dee741a2c2f272e5c9
Author: Eric Engestrom <eric.engestrom at intel.com>
Date: Wed Nov 6 19:53:28 2019 +0000
egl: move #include of local headers out of Khronos headers
Cc: mesa-stable at lists.freedesktop.org
Signed-off-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
(cherry picked from commit eaf43966027cf9654e91ca57aecc8f5a65b58f49)
More information about the mesa-commit
mailing list