Mesa (staging/19.2): mesa: don't forget to clear _Layer field on texture unit
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Oct 1 22:31:05 UTC 2019
Module: Mesa
Branch: staging/19.2
Commit: 2bbe4c69c83a3a0ac1a5925ec9c81164feff569e
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=2bbe4c69c83a3a0ac1a5925ec9c81164feff569e
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Tue Oct 1 11:55:46 2019 +0300
mesa: don't forget to clear _Layer field on texture unit
On the Android Antutu benchmark we ran into an assert in ISL where the
(base layer + num layers) > total layers. It turns out the core of
mesa forgot to clear the _Layer variable, potentially leaving an
inconsistent value.
v2: Pull setting u->_Layer out of the conditional blocks (Jason)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Cc: <mesa-stable at lists.freedesktop.org>
Reviewed-by: Eric Engestrom <eric.engestrom at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
(cherry picked from commit 2208d79ddeebd1673f477611d508566ef82bd7c0)
---
src/mesa/main/shaderimage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c
index 1712483c415..a5e85b02afc 100644
--- a/src/mesa/main/shaderimage.c
+++ b/src/mesa/main/shaderimage.c
@@ -593,11 +593,11 @@ set_image_binding(struct gl_image_unit *u, struct gl_texture_object *texObj,
if (texObj && _mesa_tex_target_is_layered(texObj->Target)) {
u->Layered = layered;
u->Layer = layer;
- u->_Layer = (u->Layered ? 0 : u->Layer);
} else {
u->Layered = GL_FALSE;
u->Layer = 0;
}
+ u->_Layer = (u->Layered ? 0 : u->Layer);
_mesa_reference_texobj(&u->TexObj, texObj);
}
More information about the mesa-commit
mailing list