Mesa (master): gallium/xlib: Fix an obvious thinko

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Sep 9 18:45:04 UTC 2019


Module: Mesa
Branch: master
Commit: 04bef9a0a6ed9cff3cbe4c43c056de95bb12d526
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=04bef9a0a6ed9cff3cbe4c43c056de95bb12d526

Author: Adam Jackson <ajax at redhat.com>
Date:   Mon Sep  9 13:59:34 2019 -0400

gallium/xlib: Fix an obvious thinko

x == !GLX_DIRECT_COLOR is a fancy way of writing x == 0, which is
clearly not what was meant.

---

 src/gallium/state_trackers/glx/xlib/xm_api.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/state_trackers/glx/xlib/xm_api.c b/src/gallium/state_trackers/glx/xlib/xm_api.c
index 86d27c42d6f..d63ea485e1b 100644
--- a/src/gallium/state_trackers/glx/xlib/xm_api.c
+++ b/src/gallium/state_trackers/glx/xlib/xm_api.c
@@ -661,7 +661,7 @@ initialize_visual_and_buffer(XMesaVisual v, XMesaBuffer b,
        * We support RGB rendering into almost any kind of visual.
        */
       const int xclass = v->visualType;
-      if (xclass != GLX_TRUE_COLOR && xclass == !GLX_DIRECT_COLOR) {
+      if (xclass != GLX_TRUE_COLOR && xclass != GLX_DIRECT_COLOR) {
 	 _mesa_warning(NULL,
             "XMesa: RGB mode rendering not supported in given visual.\n");
 	 return GL_FALSE;




More information about the mesa-commit mailing list