Mesa (master): aco: fix file leak in ra_fail()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Aug 20 14:53:54 UTC 2020


Module: Mesa
Branch: master
Commit: 58817bda8bccc7d5803f69fb029ae741dbf2a814
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=58817bda8bccc7d5803f69fb029ae741dbf2a814

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Thu Aug 20 09:41:46 2020 +0200

aco: fix file leak in ra_fail()

Fixes: c2b1978aa47 ("aco: rework the way various compilation/validation errors are reported")
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6399>

---

 src/amd/compiler/aco_validate.cpp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/compiler/aco_validate.cpp b/src/amd/compiler/aco_validate.cpp
index b109c41a72a..0d74458519c 100644
--- a/src/amd/compiler/aco_validate.cpp
+++ b/src/amd/compiler/aco_validate.cpp
@@ -512,6 +512,7 @@ bool ra_fail(Program *program, Location loc, Location loc2, const char *fmt, ...
       aco_print_instr(loc2.instr, memf);
    }
    fprintf(memf, "\n\n");
+   fclose(memf);
 
    aco_err(program, out);
    free(out);



More information about the mesa-commit mailing list