Mesa (master): intel/gen12+: Reserve 4KB of URB space per bank for Compute Engine

[GitLab Mirror]

Module: Mesa
Branch: master
Commit: 00a84c170a0a495f21008a80557a1d2b8257ea56
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=00a84c170a0a495f21008a80557a1d2b8257ea56

Author: Anuj Phogat <anuj.phogat at gmail.com>
Date:   Fri Jan 31 09:31:29 2020 -0800

intel/gen12+: Reserve 4KB of URB space per bank for Compute Engine

This patch is required to fix 11K+ vulkan CTS failures we were
getting with way_size_per_bank of 4 (see next patch).

Thanks to Sagar Ghuge and Jordan Justen for all the hard work of
debugging and testing.

Signed-off-by: Anuj Phogat <anuj.phogat at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Reviewed-by: Sagar Ghuge<sagar.ghuge at intel.com>

---

 src/intel/common/gen_urb_config.c | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/src/intel/common/gen_urb_config.c b/src/intel/common/gen_urb_config.c
index 5a60ca1ef11..0b819f4c937 100644
--- a/src/intel/common/gen_urb_config.c
+++ b/src/intel/common/gen_urb_config.c
@@ -65,7 +65,25 @@ gen_get_urb_config(const struct gen_device_info *devinfo,
                    unsigned entries[4], unsigned start[4],
                    enum gen_urb_deref_block_size *deref_block_size)
 {
-   const unsigned urb_size_kB = gen_get_l3_config_urb_size(devinfo, l3_cfg);
+   unsigned urb_size_kB = gen_get_l3_config_urb_size(devinfo, l3_cfg);
+
+   /* RCU_MODE register for Gen12+ in BSpec says:
+    *
+    *    "HW reserves 4KB of URB space per bank for Compute Engine out of the
+    *    total storage available in L3. SW must consider that 4KB of storage
+    *    per bank will be reduced from what is programmed for the URB space
+    *    in L3 for Render Engine executed workloads.
+    *
+    *    Example: When URB space programmed is 64KB (per bank) for Render
+    *    Engine, the actual URB space available for operation is only 60KB
+    *    (per bank). Similarly when URB space programmed is 128KB (per bank)
+    *    for render engine, the actual URB space available for operation is
+    *    only 124KB (per bank). More detailed descripton available in "L3
+    *    Cache" section of the B-Spec."
+    */
+   if (devinfo->gen >= 12)
+      urb_size_kB -= 4 * devinfo->l3_banks;
+
    const unsigned push_constant_kB =
       (devinfo->gen >= 8 || (devinfo->is_haswell && devinfo->gt == 3)) ? 32 : 16;