Mesa (master): anv: Drop unneeded struct keywords
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Jan 3 18:33:59 UTC 2020
Module: Mesa
Branch: master
Commit: 9bd8000c6c3742ac36ff79ef3566bea0851a1682
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9bd8000c6c3742ac36ff79ef3566bea0851a1682
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Fri Jan 3 11:20:22 2020 -0600
anv: Drop unneeded struct keywords
All VkFoo structs are typedef'd to not need the struct keyword. Leaving
it in there is just extra characters and breaks Vulkan's aliasing when
stuff gets promoted to core versions. It's better to just never use
struct for VkFoo.
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
---
src/intel/vulkan/anv_android.c | 4 ++--
src/intel/vulkan/anv_android.h | 2 +-
src/intel/vulkan/anv_android_stubs.c | 2 +-
src/intel/vulkan/anv_descriptor_set.c | 2 +-
src/intel/vulkan/anv_device.c | 2 +-
src/intel/vulkan/anv_formats.c | 4 ++--
src/intel/vulkan/anv_image.c | 6 +++---
src/intel/vulkan/anv_pass.c | 2 +-
src/intel/vulkan/anv_private.h | 8 ++++----
src/intel/vulkan/genX_state.c | 4 ++--
10 files changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 6a411a9b798..31b3f0d1139 100644
--- a/src/intel/vulkan/anv_android.c
+++ b/src/intel/vulkan/anv_android.c
@@ -389,14 +389,14 @@ VkResult
anv_image_from_external(
VkDevice device_h,
const VkImageCreateInfo *base_info,
- const struct VkExternalMemoryImageCreateInfo *create_info,
+ const VkExternalMemoryImageCreateInfo *create_info,
const VkAllocationCallbacks *alloc,
VkImage *out_image_h)
{
#if ANDROID_API_LEVEL >= 26
ANV_FROM_HANDLE(anv_device, device, device_h);
- const struct VkExternalFormatANDROID *ext_info =
+ const VkExternalFormatANDROID *ext_info =
vk_find_struct_const(base_info->pNext, EXTERNAL_FORMAT_ANDROID);
if (ext_info && ext_info->externalFormat != 0) {
diff --git a/src/intel/vulkan/anv_android.h b/src/intel/vulkan/anv_android.h
index d5c073126e3..809b0603616 100644
--- a/src/intel/vulkan/anv_android.h
+++ b/src/intel/vulkan/anv_android.h
@@ -40,7 +40,7 @@ VkResult anv_image_from_gralloc(VkDevice device_h,
VkResult anv_image_from_external(VkDevice device_h,
const VkImageCreateInfo *base_info,
- const struct VkExternalMemoryImageCreateInfo *create_info,
+ const VkExternalMemoryImageCreateInfo *create_info,
const VkAllocationCallbacks *alloc,
VkImage *out_image_h);
diff --git a/src/intel/vulkan/anv_android_stubs.c b/src/intel/vulkan/anv_android_stubs.c
index a34afc198a1..3e773dfe710 100644
--- a/src/intel/vulkan/anv_android_stubs.c
+++ b/src/intel/vulkan/anv_android_stubs.c
@@ -59,7 +59,7 @@ anv_create_ahw_memory(VkDevice device_h,
VkResult
anv_image_from_external(VkDevice device_h,
const VkImageCreateInfo *base_info,
- const struct VkExternalMemoryImageCreateInfo *create_info,
+ const VkExternalMemoryImageCreateInfo *create_info,
const VkAllocationCallbacks *alloc,
VkImage *out_image_h)
{
diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c
index 020b6abd5ed..4f458150a34 100644
--- a/src/intel/vulkan/anv_descriptor_set.c
+++ b/src/intel/vulkan/anv_descriptor_set.c
@@ -985,7 +985,7 @@ anv_descriptor_set_create(struct anv_device *device,
* will always write in the immutable sampler regardless of what
* is in the sampler parameter.
*/
- struct VkDescriptorImageInfo info = { };
+ VkDescriptorImageInfo info = { };
anv_descriptor_set_write_image_view(device, set, &info,
VK_DESCRIPTOR_TYPE_SAMPLER,
b, i);
diff --git a/src/intel/vulkan/anv_device.c b/src/intel/vulkan/anv_device.c
index 3b4f40a998d..c6d31190a68 100644
--- a/src/intel/vulkan/anv_device.c
+++ b/src/intel/vulkan/anv_device.c
@@ -3186,7 +3186,7 @@ VkResult anv_AllocateMemory(
if (result != VK_SUCCESS)
goto fail;
- const struct VkImportAndroidHardwareBufferInfoANDROID import_info = {
+ const VkImportAndroidHardwareBufferInfoANDROID import_info = {
.buffer = mem->ahw,
};
result = anv_import_ahw_memory(_device, mem, &import_info);
diff --git a/src/intel/vulkan/anv_formats.c b/src/intel/vulkan/anv_formats.c
index 9431dab6012..1ba18191c2c 100644
--- a/src/intel/vulkan/anv_formats.c
+++ b/src/intel/vulkan/anv_formats.c
@@ -1026,7 +1026,7 @@ VkResult anv_GetPhysicalDeviceImageFormatProperties2(
const VkPhysicalDeviceExternalImageFormatInfo *external_info = NULL;
VkExternalImageFormatProperties *external_props = NULL;
VkSamplerYcbcrConversionImageFormatProperties *ycbcr_props = NULL;
- struct VkAndroidHardwareBufferUsageANDROID *android_usage = NULL;
+ VkAndroidHardwareBufferUsageANDROID *android_usage = NULL;
VkResult result;
/* Extract input structs */
@@ -1221,7 +1221,7 @@ VkResult anv_CreateSamplerYcbcrConversion(
/* Search for VkExternalFormatANDROID and resolve the format. */
struct anv_format *ext_format = NULL;
- const struct VkExternalFormatANDROID *ext_info =
+ const VkExternalFormatANDROID *ext_info =
vk_find_struct_const(pCreateInfo->pNext, EXTERNAL_FORMAT_ANDROID);
uint64_t format = ext_info ? ext_info->externalFormat : 0;
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c
index 2e6ca82dabc..f2f89a012b6 100644
--- a/src/intel/vulkan/anv_image.c
+++ b/src/intel/vulkan/anv_image.c
@@ -745,7 +745,7 @@ anv_CreateImage(VkDevice device,
const VkAllocationCallbacks *pAllocator,
VkImage *pImage)
{
- const struct VkExternalMemoryImageCreateInfo *create_info =
+ const VkExternalMemoryImageCreateInfo *create_info =
vk_find_struct_const(pCreateInfo->pNext, EXTERNAL_MEMORY_IMAGE_CREATE_INFO);
if (create_info && (create_info->handleTypes &
@@ -754,7 +754,7 @@ anv_CreateImage(VkDevice device,
pAllocator, pImage);
bool use_external_format = false;
- const struct VkExternalFormatANDROID *ext_format =
+ const VkExternalFormatANDROID *ext_format =
vk_find_struct_const(pCreateInfo->pNext, EXTERNAL_FORMAT_ANDROID);
/* "If externalFormat is zero, the effect is as if the
@@ -1590,7 +1590,7 @@ anv_CreateImageView(VkDevice _device,
/* Check if a conversion info was passed. */
const struct anv_format *conv_format = NULL;
- const struct VkSamplerYcbcrConversionInfo *conv_info =
+ const VkSamplerYcbcrConversionInfo *conv_info =
vk_find_struct_const(pCreateInfo->pNext, SAMPLER_YCBCR_CONVERSION_INFO);
/* If image has an external format, the pNext chain must contain an instance of
diff --git a/src/intel/vulkan/anv_pass.c b/src/intel/vulkan/anv_pass.c
index 94783bb36c4..067d9d55d67 100644
--- a/src/intel/vulkan/anv_pass.c
+++ b/src/intel/vulkan/anv_pass.c
@@ -338,7 +338,7 @@ VkResult anv_CreateRenderPass(
for (uint32_t i = 0; i < pCreateInfo->dependencyCount; i++) {
/* Convert to a Dependency2KHR */
- struct VkSubpassDependency2KHR dep2 = {
+ VkSubpassDependency2KHR dep2 = {
.srcSubpass = pCreateInfo->pDependencies[i].srcSubpass,
.dstSubpass = pCreateInfo->pDependencies[i].dstSubpass,
.srcStageMask = pCreateInfo->pDependencies[i].srcStageMask,
diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h
index 32bb027142e..dd47df9a09d 100644
--- a/src/intel/vulkan/anv_private.h
+++ b/src/intel/vulkan/anv_private.h
@@ -3812,9 +3812,9 @@ anv_image_get_surface_for_aspect_mask(const struct anv_image *image,
enum isl_format
anv_isl_format_for_descriptor_type(VkDescriptorType type);
-static inline struct VkExtent3D
+static inline VkExtent3D
anv_sanitize_image_extent(const VkImageType imageType,
- const struct VkExtent3D imageExtent)
+ const VkExtent3D imageExtent)
{
switch (imageType) {
case VK_IMAGE_TYPE_1D:
@@ -3828,9 +3828,9 @@ anv_sanitize_image_extent(const VkImageType imageType,
}
}
-static inline struct VkOffset3D
+static inline VkOffset3D
anv_sanitize_image_offset(const VkImageType imageType,
- const struct VkOffset3D imageOffset)
+ const VkOffset3D imageOffset)
{
switch (imageType) {
case VK_IMAGE_TYPE_1D:
diff --git a/src/intel/vulkan/genX_state.c b/src/intel/vulkan/genX_state.c
index 8ad048225a6..34c6c6bd142 100644
--- a/src/intel/vulkan/genX_state.c
+++ b/src/intel/vulkan/genX_state.c
@@ -447,8 +447,8 @@ VkResult genX(CreateSampler)(
}
#if GEN_GEN >= 9
case VK_STRUCTURE_TYPE_SAMPLER_REDUCTION_MODE_CREATE_INFO_EXT: {
- struct VkSamplerReductionModeCreateInfoEXT *sampler_reduction =
- (struct VkSamplerReductionModeCreateInfoEXT *) ext;
+ VkSamplerReductionModeCreateInfoEXT *sampler_reduction =
+ (VkSamplerReductionModeCreateInfoEXT *) ext;
sampler_reduction_mode =
vk_to_gen_sampler_reduction_mode[sampler_reduction->reductionMode];
enable_sampler_reduction = true;
More information about the mesa-commit
mailing list