Mesa (master): radv: fix duplicated expression in ac_setup_rings()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu May 21 08:08:23 UTC 2020


Module: Mesa
Branch: master
Commit: 57a4837f6be2b0c8b6a9174d0a385c7f0bfb00e1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=57a4837f6be2b0c8b6a9174d0a385c7f0bfb00e1

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed May 20 19:59:50 2020 +0200

radv: fix duplicated expression in ac_setup_rings()

Probably a search&replace mistake when that common struct was
introduced.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3006
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5130>

---

 src/amd/vulkan/radv_nir_to_llvm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_nir_to_llvm.c b/src/amd/vulkan/radv_nir_to_llvm.c
index 51416262df1..d8b43c0ea64 100644
--- a/src/amd/vulkan/radv_nir_to_llvm.c
+++ b/src/amd/vulkan/radv_nir_to_llvm.c
@@ -3712,7 +3712,7 @@ ac_setup_rings(struct radv_shader_context *ctx)
 {
 	if (ctx->args->options->chip_class <= GFX8 &&
 	    (ctx->stage == MESA_SHADER_GEOMETRY ||
-	     ctx->args->options->key.vs_common_out.as_es || ctx->args->options->key.vs_common_out.as_es)) {
+	     ctx->args->options->key.vs_common_out.as_es)) {
 		unsigned ring = ctx->stage == MESA_SHADER_GEOMETRY ? RING_ESGS_GS
 								   : RING_ESGS_VS;
 		LLVMValueRef offset = LLVMConstInt(ctx->ac.i32, ring, false);



More information about the mesa-commit mailing list