Mesa (master): radv/winsys: remove useless free in radv_amdgpu_create_bo_list()

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu May 21 08:27:10 UTC 2020


Module: Mesa
Branch: master
Commit: a3045cbc97d7417e3036ba8f1f6f5189c1254407
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a3045cbc97d7417e3036ba8f1f6f5189c1254407

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed May 20 20:04:34 2020 +0200

radv/winsys: remove useless free in radv_amdgpu_create_bo_list()

free(NULL) is fine but let's remove it.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3008
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5131>

---

 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index de6bd6546ed..00927413ee2 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
@@ -731,10 +731,8 @@ static int radv_amdgpu_create_bo_list(struct radv_amdgpu_winsys *ws,
 			return 0;
 		}
 		struct drm_amdgpu_bo_list_entry *handles = malloc(sizeof(struct drm_amdgpu_bo_list_entry) * total_buffer_count);
-		if (!handles) {
-			free(handles);
+		if (!handles)
 			return -ENOMEM;
-		}
 
 		for (unsigned i = 0; i < num_extra_bo; i++) {
 			handles[i].bo_handle = extra_bo_array[i]->bo_handle;



More information about the mesa-commit mailing list