Mesa (master): radv: Deal with unused attachments in mip flush

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 27 18:44:50 UTC 2020


Module: Mesa
Branch: master
Commit: aed8d30b507568b7fc0f32afca012f8def5aca16
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=aed8d30b507568b7fc0f32afca012f8def5aca16

Author: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Date:   Fri Nov 27 15:07:17 2020 +0100

radv: Deal with unused attachments in mip flush

Fixes: 4cce4d22a72 ("radv: Fix a hang on CB change by adding flushes.")
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7813>

---

 src/amd/vulkan/radv_cmd_buffer.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 5a7ea937c19..51b430573a2 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2258,6 +2258,9 @@ radv_emit_fb_mip_change_flush(struct radv_cmd_buffer *cmd_buffer)
 
 	for (int i = 0; i < subpass->color_count; ++i) {
 		int idx = subpass->color_attachments[i].attachment;
+		if (idx == VK_ATTACHMENT_UNUSED)
+			continue;
+
 		struct radv_image_view *iview = cmd_buffer->state.attachments[idx].iview;
 
 		if ((radv_image_has_CB_metadata(iview->image) ||



More information about the mesa-commit mailing list