Mesa (master): nir: Update some comments referring to imov

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Apr 19 20:32:04 UTC 2021


Module: Mesa
Branch: master
Commit: 899dd8e60a5228c4506400d621ef6b5abfe5e32c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=899dd8e60a5228c4506400d621ef6b5abfe5e32c

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Fri Apr 16 19:40:14 2021 -0400

nir: Update some comments referring to imov

This was renamed when I was in high school. I remember updating the
Midgard compiler while sitting in AP Physics.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10296>

---

 src/compiler/nir/nir_builder.h  | 2 +-
 src/compiler/nir/nir_from_ssa.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builder.h
index 37711abe68c..b5b0ba365bf 100644
--- a/src/compiler/nir/nir_builder.h
+++ b/src/compiler/nir/nir_builder.h
@@ -570,7 +570,7 @@ nir_mov_alu(nir_builder *build, nir_alu_src src, unsigned num_components)
 }
 
 /**
- * Construct an fmov or imov that reswizzles the source's components.
+ * Construct a mov that reswizzles the source's components.
  */
 static inline nir_ssa_def *
 nir_swizzle(nir_builder *build, nir_ssa_def *src, const unsigned *swiz,
diff --git a/src/compiler/nir/nir_from_ssa.c b/src/compiler/nir/nir_from_ssa.c
index e3b2d16a8fb..f1871db6cc2 100644
--- a/src/compiler/nir/nir_from_ssa.c
+++ b/src/compiler/nir/nir_from_ssa.c
@@ -937,10 +937,10 @@ place_phi_read(nir_builder *b, nir_register *reg,
    nir_store_reg(b, reg, def, ~0);
 }
 
-/** Lower all of the phi nodes in a block to imovs to and from a register
+/** Lower all of the phi nodes in a block to movs to and from a register
  *
  * This provides a very quick-and-dirty out-of-SSA pass that you can run on a
- * single block to convert all of its phis to a register and some imovs.
+ * single block to convert all of its phis to a register and some movs.
  * The code that is generated, while not optimal for actual codegen in a
  * back-end, is easy to generate, correct, and will turn into the same set of
  * phis after you call regs_to_ssa and do some copy propagation.



More information about the mesa-commit mailing list