Mesa (master): panfrost: Set allow_forward_pixel_to_be_killed for blit

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Apr 19 20:52:38 UTC 2021


Module: Mesa
Branch: master
Commit: d0344619214b43db8bc5a928dd09d1fcf8f725fc
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d0344619214b43db8bc5a928dd09d1fcf8f725fc

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu Apr 15 18:10:24 2021 -0400

panfrost: Set allow_forward_pixel_to_be_killed for blit

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Boris Brezillon <boris.brezillon at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10271>

---

 src/panfrost/lib/pan_blitter.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/panfrost/lib/pan_blitter.c b/src/panfrost/lib/pan_blitter.c
index 76d9a96a4a8..701f12c92d9 100644
--- a/src/panfrost/lib/pan_blitter.c
+++ b/src/panfrost/lib/pan_blitter.c
@@ -166,9 +166,11 @@ pan_blitter_prepare_bifrost_rsd(const struct panfrost_device *dev,
 
         /* We can only allow blit shader fragments to kill if they write all
          * colour outputs. This is true for our colour (non-Z/S) blit shaders,
-         * but obviously not true for Z/S shaders. */
+         * but obviously not true for Z/S shaders. However, blit shaders
+         * otherwise lack side effects, so other fragments may kill them. */
 
         rsd->properties.bifrost.allow_forward_pixel_to_kill = !(z || s);
+        rsd->properties.bifrost.allow_forward_pixel_to_be_killed = true;
 
         rsd->preload.fragment.coverage = true;
         rsd->preload.fragment.sample_mask_id = ms;



More information about the mesa-commit mailing list