Mesa (main): radeonsi: don't use perp. end caps when line smoothing is on

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: c1860a68483ebd0ca859fa24fc0e0426d862d0a9
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c1860a68483ebd0ca859fa24fc0e0426d862d0a9

Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Thu Dec 16 12:06:52 2021 +0100

radeonsi: don't use perp. end caps when line smoothing is on

The line smoothing algorithm causes the diagonal line to be visible.

See: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13700#note_1187405

Fixes: 45717780082 ("radeonsi: set PERPENDICULAR_ENDCAP_ENA for wide AA lines")
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14226>

---

 src/gallium/drivers/radeonsi/si_state.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
index c942b334c92..e82235d7f51 100644
--- a/src/gallium/drivers/radeonsi/si_state.c
+++ b/src/gallium/drivers/radeonsi/si_state.c
@@ -951,7 +951,7 @@ static void *si_create_rs_state(struct pipe_context *ctx, const struct pipe_rast
                                : 0;
    /* TODO: implement line stippling with perpendicular end caps. */
    /* Line width > 2 is an internal recommendation. */
-   rs->perpendicular_end_caps = (state->multisample || state->line_smooth) &&
+   rs->perpendicular_end_caps = state->multisample &&
                                 state->line_width > 2 && !state->line_stipple_enable;
 
    rs->pa_cl_clip_cntl = S_028810_DX_CLIP_SPACE_DEF(state->clip_halfz) |