Mesa (master): radv: do not enable DCC for 3D images with mipmaps on GFX10+

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jan 13 14:00:35 UTC 2021


Module: Mesa
Branch: master
Commit: 825e2386dc3e5381cacb3ed1be8241b56e7d5798
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=825e2386dc3e5381cacb3ed1be8241b56e7d5798

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Jan 13 10:37:19 2021 +0100

radv: do not enable DCC for 3D images with mipmaps on GFX10+

This is broken for some reasons, and probably rare enough to
care for now.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8468>

---

 src/amd/vulkan/radv_image.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c
index 0ed0e07eaf8..371df177030 100644
--- a/src/amd/vulkan/radv_image.c
+++ b/src/amd/vulkan/radv_image.c
@@ -178,6 +178,12 @@ radv_use_dcc_for_image(struct radv_device *device,
 	if (!radv_image_use_fast_clear_for_image(device, image))
 		return false;
 
+	/* FIXME: DCC for 3D images with mimaps are broken on GFX10+. */
+        if (pCreateInfo->mipLevels > 1 &&
+           pCreateInfo->imageType == VK_IMAGE_TYPE_3D &&
+           device->physical_device->rad_info.chip_class >= GFX10)
+                return false;
+
 	/* TODO: Enable DCC for mipmaps on GFX9+. */
 	if (pCreateInfo->mipLevels > 1 &&
 	    device->physical_device->rad_info.chip_class >= GFX9)



More information about the mesa-commit mailing list