Mesa (master): radv: add a comment explaining the micro tile mode resolve

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jan 19 18:15:29 UTC 2021


Module: Mesa
Branch: master
Commit: 60ead6e04becf00e928d1e30a279f71cb0ce0e4a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=60ead6e04becf00e928d1e30a279f71cb0ce0e4a

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Jan 19 08:26:42 2021 +0100

radv: add a comment explaining the micro tile mode resolve

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8558>

---

 src/amd/vulkan/radv_meta_resolve.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c
index 5a02dd5bb28..8258b9a04e8 100644
--- a/src/amd/vulkan/radv_meta_resolve.c
+++ b/src/amd/vulkan/radv_meta_resolve.c
@@ -378,6 +378,10 @@ static void radv_pick_resolve_method_images(struct radv_device *device,
 			*method = RESOLVE_FRAGMENT;
 		} else if (dest_image->planes[0].surface.micro_tile_mode !=
 		           src_image->planes[0].surface.micro_tile_mode) {
+			/* The micro tile mode only needs to match for the HW
+			 * resolve path which is the default path for non-DCC
+			 * resolves.
+			 */
 			*method = RESOLVE_COMPUTE;
 		}
 



More information about the mesa-commit mailing list