Mesa (main): pan/bi: Confirm IDP unit on Valhall

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 36486f54e97fe35daf42fc7705715db9e1304a11
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=36486f54e97fe35daf42fc7705715db9e1304a11

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Sun Nov  7 19:50:51 2021 -0500

pan/bi: Confirm IDP unit on Valhall

Based on Anandtech which gives 8-bit dot product throughput on Valhall
under FMA and not consistent with SFU.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13802>

---

 src/panfrost/bifrost/valhall/ISA.xml | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/panfrost/bifrost/valhall/ISA.xml b/src/panfrost/bifrost/valhall/ISA.xml
index cc5a1c0bab2..09872ab0e9d 100644
--- a/src/panfrost/bifrost/valhall/ISA.xml
+++ b/src/panfrost/bifrost/valhall/ISA.xml
@@ -1538,8 +1538,7 @@
     <src absneg="true">Z coordinate as 32-bit floating point</src>
   </ins>
 
-  <group name="IDP" title="8-bit dot product" dests="1" opcode="0xC2" unit="SFU">
-    <!-- TODO: confirm unit -->
+  <group name="IDP" title="8-bit dot product" dests="1" opcode="0xC2" unit="FMA">
     <desc>
       8-bit integer dot product between 4 channel vectors, intended for machine
       learning. Available in both unsigned and signed variants, controlling