Mesa (main): radv: don't create blit pipelines for multisampled 3D images

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Oct 7 17:52:54 UTC 2021


Module: Mesa
Branch: main
Commit: d30ed6ef8becd7ac3f6342b1cd655fe6da2f76c8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d30ed6ef8becd7ac3f6342b1cd655fe6da2f76c8

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Wed Aug  4 18:40:48 2021 +0100

radv: don't create blit pipelines for multisampled 3D images

These don't create sensible NIR.

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12214>

---

 src/amd/vulkan/radv_meta_blit2d.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/amd/vulkan/radv_meta_blit2d.c b/src/amd/vulkan/radv_meta_blit2d.c
index 8ebc6c82aca..8ae8df2bc49 100644
--- a/src/amd/vulkan/radv_meta_blit2d.c
+++ b/src/amd/vulkan/radv_meta_blit2d.c
@@ -1321,6 +1321,10 @@ radv_device_init_meta_blit2d_state(struct radv_device *device, bool on_demand)
          if (src == BLIT2D_SRC_TYPE_BUFFER && log2_samples > 0)
             continue;
 
+         /* There are no multisampled 3D images. */
+         if (src == BLIT2D_SRC_TYPE_IMAGE_3D && log2_samples > 0)
+            continue;
+
          result = meta_blit2d_create_pipe_layout(device, src, log2_samples);
          if (result != VK_SUCCESS)
             goto fail;



More information about the mesa-commit mailing list