Mesa (main): aux/pb: more correctly check number of reclaims

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Oct 15 23:58:55 UTC 2021


Module: Mesa
Branch: main
Commit: fe2674dd52dd63e6fb4a69e037a7cb5266049e4a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fe2674dd52dd63e6fb4a69e037a7cb5266049e4a

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Fri Oct 15 16:01:52 2021 -0400

aux/pb: more correctly check number of reclaims

the increment needs to happen before the comparison here

Fixes: 3d6c8829f54 ("aux/pb: add a tolerance for reclaim failure")

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13388>

---

 src/gallium/auxiliary/pipebuffer/pb_slab.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/auxiliary/pipebuffer/pb_slab.c b/src/gallium/auxiliary/pipebuffer/pb_slab.c
index 865ae92ee7f..83c1a597fe7 100644
--- a/src/gallium/auxiliary/pipebuffer/pb_slab.c
+++ b/src/gallium/auxiliary/pipebuffer/pb_slab.c
@@ -89,7 +89,7 @@ pb_slabs_reclaim_locked(struct pb_slabs *slabs)
        * the driver should not walk the entire list, as this is likely to
        * result in zero reclaims if the first few entries fail to reclaim
        */
-      } else if (num_failed_reclaims++ > MAX_FAILED_RECLAIMS) {
+      } else if (++num_failed_reclaims >= MAX_FAILED_RECLAIMS) {
          break;
       }
    }



More information about the mesa-commit mailing list