Mesa (staging/21.3): aco: fix emitting stream outputs when the first component isn't zero
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Oct 19 20:59:46 UTC 2021
Module: Mesa
Branch: staging/21.3
Commit: 6580db8b7efdc4941b818d718596a8bc1d0c07dd
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6580db8b7efdc4941b818d718596a8bc1d0c07dd
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Tue Oct 19 13:27:55 2021 +0200
aco: fix emitting stream outputs when the first component isn't zero
Fixes a bunch of XFB piglit tests with Zink.
Cc: 21.3 mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13437>
(cherry picked from commit 572a902566471b882267d0193784d2afd05ca4ba)
---
.pick_status.json | 2 +-
src/amd/compiler/aco_instruction_selection.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index 179dc28db45..4c07889f564 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -247,7 +247,7 @@
"description": "aco: fix emitting stream outputs when the first component isn't zero",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index eeb314a9e1d..b28bd57676b 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -11172,7 +11172,7 @@ emit_stream_output(isel_context* ctx, Temp const* so_buffers, Temp const* so_wri
aco_opcode::p_create_vector, Format::PSEUDO, count, 1)};
for (int i = 0; i < count; ++i)
vec->operands[i] =
- (ctx->outputs.mask[loc] & 1 << (start + i)) ? Operand(out[start + i]) : Operand::zero();
+ (ctx->outputs.mask[loc] & 1 << (start + first_comp + i)) ? Operand(out[start + i]) : Operand::zero();
vec->definitions[0] = Definition(write_data);
ctx->block->instructions.emplace_back(std::move(vec));
More information about the mesa-commit
mailing list