Mesa (staging/21.3): zink: fully zero surface creation struct

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Oct 19 20:59:46 UTC 2021


Module: Mesa
Branch: staging/21.3
Commit: c3cb359cc5275c9495493dc94f1cb811233e824d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c3cb359cc5275c9495493dc94f1cb811233e824d

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Mon Oct 18 10:40:12 2021 -0400

zink: fully zero surface creation struct

gotta get those holes for caching

cc: mesa-stable

Reviewed-by: Hoe Hao Cheng <haochengho12907 at gmail.com>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13410>
(cherry picked from commit e66558985a9e85393ff844f8a16e85b4cf812f0e)

---

 .pick_status.json                       | 2 +-
 src/gallium/drivers/zink/zink_surface.c | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/.pick_status.json b/.pick_status.json
index 2eb17b3eea5..a77fe69d78b 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -544,7 +544,7 @@
         "description": "zink: fully zero surface creation struct",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": null
     },
diff --git a/src/gallium/drivers/zink/zink_surface.c b/src/gallium/drivers/zink/zink_surface.c
index 44e0c11344a..08dc0057ffa 100644
--- a/src/gallium/drivers/zink/zink_surface.c
+++ b/src/gallium/drivers/zink/zink_surface.c
@@ -37,7 +37,9 @@ create_ivci(struct zink_screen *screen,
             const struct pipe_surface *templ,
             enum pipe_texture_target target)
 {
-   VkImageViewCreateInfo ivci = {0};
+   VkImageViewCreateInfo ivci;
+   /* zero holes since this is hashed */
+   memset(&ivci, 0, sizeof(VkImageViewCreateInfo));
    ivci.sType = VK_STRUCTURE_TYPE_IMAGE_VIEW_CREATE_INFO;
    ivci.image = res->obj->image;
 



More information about the mesa-commit mailing list