Mesa (main): glsl: Don't split structures in the condition of an assignment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Feb 11 17:59:12 UTC 2022


Module: Mesa
Branch: main
Commit: 2652b9a83d70b2492674625136b70b714743b307
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2652b9a83d70b2492674625136b70b714743b307

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Jan 14 18:51:19 2022 -0800

glsl: Don't split structures in the condition of an assignment

At this point, this should always be NULL.

v2: Fix bad rebase.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14573>

---

 src/compiler/glsl/opt_structure_splitting.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/compiler/glsl/opt_structure_splitting.cpp b/src/compiler/glsl/opt_structure_splitting.cpp
index c573d07c266..89e08f0b062 100644
--- a/src/compiler/glsl/opt_structure_splitting.cpp
+++ b/src/compiler/glsl/opt_structure_splitting.cpp
@@ -293,8 +293,6 @@ ir_structure_splitting_visitor::visit_leave(ir_assignment *ir)
       split_deref(&ir->lhs);
    }
 
-   handle_rvalue(&ir->condition);
-
    return visit_continue;
 }
 



More information about the mesa-commit mailing list