Mesa (main): glsl: Don't lower vector indexing in the condition of an assignment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Feb 11 17:59:12 UTC 2022


Module: Mesa
Branch: main
Commit: 1c22f069700aec8fe7c0f381a63345cb39cd9695
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c22f069700aec8fe7c0f381a63345cb39cd9695

Author: Ian Romanick <ian.d.romanick at intel.com>
Date:   Fri Jan 14 18:53:59 2022 -0800

glsl: Don't lower vector indexing in the condition of an assignment

At this point, this should always be NULL.

Reviewed-by: Matt Turner <mattst88 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14573>

---

 src/compiler/glsl/lower_vec_index_to_cond_assign.cpp | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/src/compiler/glsl/lower_vec_index_to_cond_assign.cpp b/src/compiler/glsl/lower_vec_index_to_cond_assign.cpp
index 70ce16c3ec1..1adf9087bd6 100644
--- a/src/compiler/glsl/lower_vec_index_to_cond_assign.cpp
+++ b/src/compiler/glsl/lower_vec_index_to_cond_assign.cpp
@@ -232,9 +232,6 @@ ir_vec_index_to_cond_assign_visitor::visit_leave(ir_assignment *ir)
 {
    ir->rhs = convert_vector_extract_to_cond_assign(ir->rhs);
 
-   if (ir->condition)
-      ir->condition = convert_vector_extract_to_cond_assign(ir->condition);
-
    return visit_continue;
 }
 



More information about the mesa-commit mailing list