Mesa (main): pan/va: Fix some units

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Feb 18 16:13:55 UTC 2022


Module: Mesa
Branch: main
Commit: 9e851e75de5875e47bac4c6a596b08a879932a2b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=9e851e75de5875e47bac4c6a596b08a879932a2b

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Thu Feb 17 14:06:16 2022 -0500

pan/va: Fix some units

Remove the todos.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15069>

---

 src/panfrost/bifrost/valhall/ISA.xml | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/panfrost/bifrost/valhall/ISA.xml b/src/panfrost/bifrost/valhall/ISA.xml
index 6ceb53f72ca..14f63c64af4 100644
--- a/src/panfrost/bifrost/valhall/ISA.xml
+++ b/src/panfrost/bifrost/valhall/ISA.xml
@@ -1344,8 +1344,7 @@
     <src/>
   </ins>
 
-  <ins name="WMASK" title="Warp mask" dests="1" opcode="0x95" unit="SFU">
-    <!-- TODO: confirm unit -->
+  <ins name="WMASK" title="Warp mask" dests="1" opcode="0x95" unit="CVT">
     <desc>
       Returns the mask of lanes ever active within the warp (subgroup), such
       that the source is nonzero. The number of work-items in a subgroup is
@@ -1552,7 +1551,6 @@
   </group>
 
   <group name="HADD" title="Integer half-add" dests="1" opcode2="0x0B" unit="CVT">
-    <!-- TODO: confirm unit -->
     <ins name="HADD.u32" opcode="0xA0"/>
     <ins name="HADD.v2u16" opcode="0xA1"/>
     <ins name="HADD.v4u8" opcode="0xA2"/>



More information about the mesa-commit mailing list