Mesa (main): ir3: Fix vectorizer condition for SSBOs
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Jun 23 11:10:52 UTC 2022
Module: Mesa
Branch: main
Commit: 7d706af76b2c41ee2d496efabcf96ac5c4a61de2
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7d706af76b2c41ee2d496efabcf96ac5c4a61de2
Author: Connor Abbott <cwabbott0 at gmail.com>
Date: Tue Jun 14 20:47:29 2022 +0200
ir3: Fix vectorizer condition for SSBOs
SSBO access works very differently from UBO access. Straddling
loads/stores isn't an issue, loads/stores instead must be aligned to the
element size and can have up to 4 components.
We support 16-bit access with SSBOs on a650+, and sometimes the
vectorizer tries to create a misaligned 32-bit access when combining
32-bit and 16-bit accesses. The UBO-focused logic didn't reject this,
which is now fixed. This fixes a number of VK-CTS regressions on a650+.
Fixes: bf49d4a084b ("freedreno/ir3: Enable load/store vectorization for SSBO access, too.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17040>
---
src/freedreno/ir3/ir3_nir.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/freedreno/ir3/ir3_nir.c b/src/freedreno/ir3/ir3_nir.c
index 519a02c0dac..009d5a884d1 100644
--- a/src/freedreno/ir3/ir3_nir.c
+++ b/src/freedreno/ir3/ir3_nir.c
@@ -37,10 +37,17 @@ ir3_nir_should_vectorize_mem(unsigned align_mul, unsigned align_offset,
nir_intrinsic_instr *low,
nir_intrinsic_instr *high, void *data)
{
+ unsigned byte_size = bit_size / 8;
+
+ if (low->intrinsic != nir_intrinsic_load_ubo) {
+ return bit_size <= 32 && align_mul >= byte_size &&
+ align_offset % byte_size == 0 &&
+ num_components <= 4;
+ }
+
assert(bit_size >= 8);
if (bit_size != 32)
return false;
- unsigned byte_size = bit_size / 8;
int size = num_components * byte_size;
More information about the mesa-commit
mailing list