Mesa (main): tu: Check dereferenced value of rop_reads_dst.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: b1df00cb7943c9869b1542c97ebb4eac81c0040c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b1df00cb7943c9869b1542c97ebb4eac81c0040c

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Thu Jun 16 15:42:29 2022 -0700

tu: Check dereferenced value of rop_reads_dst.

Fix defect reported by Coverity Scan.

Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking rop_reads_dst suggests that it may be
null, but it has already been dereferenced on all paths leading to the
check.

Fixes: 94be0dd0b86 ("tu: Implement extendedDynamicState2LogicOp")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17099>

---

 src/freedreno/vulkan/tu_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/freedreno/vulkan/tu_pipeline.c b/src/freedreno/vulkan/tu_pipeline.c
index 6e5a797f3c5..815ce4d4206 100644
--- a/src/freedreno/vulkan/tu_pipeline.c
+++ b/src/freedreno/vulkan/tu_pipeline.c
@@ -2212,7 +2212,7 @@ tu6_emit_rb_mrt_controls(struct tu_pipeline *pipeline,
          if (att->blendEnable)
             pipeline->blend_enable |= BIT(i);
 
-         if (att->blendEnable || rop_reads_dst) {
+         if (att->blendEnable || *rop_reads_dst) {
             total_bpp += write_bpp;
          }
       }