Mesa (main): aco: correctly validate v_fma_mixhi_f16 register assignment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Jun 27 15:30:53 UTC 2022


Module: Mesa
Branch: main
Commit: c298ab0d2362db180dfb8d619125916aa66c07a8
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c298ab0d2362db180dfb8d619125916aa66c07a8

Author: Daniel Schürmann <daniel at schuermann.dev>
Date:   Wed Jun  1 17:16:55 2022 +0200

aco: correctly validate v_fma_mixhi_f16 register assignment

Reviewed-by: Georg Lehmann <dadschoorse at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15176>

---

 src/amd/compiler/aco_ir.cpp       | 1 +
 src/amd/compiler/aco_validate.cpp | 1 +
 2 files changed, 2 insertions(+)

diff --git a/src/amd/compiler/aco_ir.cpp b/src/amd/compiler/aco_ir.cpp
index 88b028d4e31..45ae5bef693 100644
--- a/src/amd/compiler/aco_ir.cpp
+++ b/src/amd/compiler/aco_ir.cpp
@@ -446,6 +446,7 @@ instr_is_16bit(amd_gfx_level gfx_level, aco_opcode op)
    case aco_opcode::v_div_fixup_f16:
    case aco_opcode::v_interp_p2_f16:
    case aco_opcode::v_fma_mixlo_f16:
+   case aco_opcode::v_fma_mixhi_f16:
    /* VOP2 */
    case aco_opcode::v_mac_f16:
    case aco_opcode::v_madak_f16:
diff --git a/src/amd/compiler/aco_validate.cpp b/src/amd/compiler/aco_validate.cpp
index dd474ef422f..87b5beefbaf 100644
--- a/src/amd/compiler/aco_validate.cpp
+++ b/src/amd/compiler/aco_validate.cpp
@@ -841,6 +841,7 @@ validate_subdword_definition(amd_gfx_level gfx_level, const aco_ptr<Instruction>
       return true;
 
    switch (instr->opcode) {
+   case aco_opcode::v_fma_mixhi_f16:
    case aco_opcode::buffer_load_ubyte_d16_hi:
    case aco_opcode::buffer_load_sbyte_d16_hi:
    case aco_opcode::buffer_load_short_d16_hi:



More information about the mesa-commit mailing list