[Mesa-dev] [PATCH] dri/r300: test for FEATURE defines

[nobled]

Chia-I Wu <olvaffe at gmail.com> wrote:
>> Fixes a fatal build error when compiling just OpenGL ES libraries, since
>> FEATURE_EXT_framebuffer_blit is disabled then, so the BlitFramebuffer
>> member doesn't exist.
> Is this change enough to make dri_r300 function as a GLES only driver?
>
> To be honest, I am a little reluctant to sprinkle "#if FEATURE" in the drivers
> at the moment.  The drivers, execept for intel, have not specified GLES api
> support yet.  Even when they do, I would hope there is a more systematic to
> enable/disable certain features, to effectively reduce the driver size.
It's already sprinkled through the DRI drivers right now though(it's
in intel_fbo.c at least), because struct dd_function_table's members
in src/mesa/main/dd.h are #if'd based on the feature defines. As it
is, the code for radeon and nouveau (and the mesa state tracker, now
that I check) is just borked without them.

(new patch for st/mesa attached)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-dri-radeon-test-for-FEATURE-defines.patch
Type: text/x-patch
Size: 1606 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100813/e49b9944/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-dri-nouveau-test-for-FEATURE-defines.patch
Type: text/x-patch
Size: 1989 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100813/e49b9944/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-st-mesa-test-for-FEATURE-defines.patch
Type: text/x-patch
Size: 1475 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20100813/e49b9944/attachment-0002.bin>