[Mesa-dev] [PATCH] dri/r300: test for FEATURE defines

[Chia-I Wu]

On Sat, Aug 14, 2010 at 5:18 AM, nobled <nobled at dreamwidth.org> wrote:
> Chia-I Wu <olvaffe at gmail.com> wrote:
>>> Fixes a fatal build error when compiling just OpenGL ES libraries, since
>>> FEATURE_EXT_framebuffer_blit is disabled then, so the BlitFramebuffer
>>> member doesn't exist.
>> Is this change enough to make dri_r300 function as a GLES only driver?
>>
>> To be honest, I am a little reluctant to sprinkle "#if FEATURE" in the drivers
>> at the moment.  The drivers, execept for intel, have not specified GLES api
>> support yet.  Even when they do, I would hope there is a more systematic to
>> enable/disable certain features, to effectively reduce the driver size.
> It's already sprinkled through the DRI drivers right now though(it's
> in intel_fbo.c at least), because struct dd_function_table's members
> in src/mesa/main/dd.h are #if'd based on the feature defines. As it
> is, the code for radeon and nouveau (and the mesa state tracker, now
> that I check) is just borked without them.
>
> (new patch for st/mesa attached)
Committed.  Thanks.



-- 
olv at LunarG.com